This repository has been archived by the owner on Dec 28, 2022. It is now read-only.
Move to electron-webpack #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚑 Fixed issues encountered (mainly TypeScript ones) in changing to electron-webpack. 👕 Added a tsconfig.json
🎨 Got electron-webpack to run app, see electron-userland/electron-webpack#83 🐛 Now need to get packages working, going to compile on a per package bases. 🎨 Using source-map as devtool 🎨 Using sindresorhus/require-fool-webpack to solve webpack/webpack-dev-server#212
This is done as the webpack build will not include access to certain files, as well as being unable to parse next gen syntax directly
🎨 Added shared code to tara-core Added: - config - constants - extensions installer (chrome) - logger - plugin-client & plugin-init - plugins
🎨 Moved all non-tara-core references in packages and tara to pointing to tara-core (i.e. ../logger.ts to tara-core/lib/logger 🎨 Got HTML working
📦 Fix node-sass build issues 🚑 Need to change Array.concat for rest spread 🚑 Error: react not found needs to be fixed (with help from @loopmode)
📦 Fixed missing packages thanks to @loopmode 🚀 Starting work on docker to isolate running
🚑 Fixed react-scroll-box install issue
…/tara into move-to-electron-webpack
|
Unable to merge or add new features until #12 is resolved. |
…/tara into move-to-electron-webpack
🎨 Use default HTML template after electron-userland/electron-webpack#101 and the findings of @loopmode 🚑 This closes #12 🎨 However, this caused themes to stop working as they were imported with our custom HTML. Thus, the theme API has been setup to load with a wrapper <Theme /> and use <style> tags (thanks to @loopmode) The theme is now directly required and compiled in the window, rather then the tara:// protocol. :art: Furthermore, the theme api has been partially refactored to allow custom HTML components to be inserted for i.e. filters Use it by setting tara.html to a compiled JSX file in package.json :bug: In order to make the updated theme API easier to debug, the layout is not loaded in the commit. :art: Added reducer to store theme CSS & HTML :art: Separated theme compiler into a separate file (src/renderer/boot/compile-theme.js) to avoid duplication of code so that tara://theme.scss could still be used. Now using async & await for it. :rocket: Due to us being unable to give tara cli options, the --debug option is now automatically enabled when NODE_ENV=development :rocket: Updated scripts/build.sh to also compile one-fluent-theme as it has custom HTML :shirt: A few linter config tweaks & code changes due to it
🎨 Now using promises for stat. 🐛 FFI will not compile, stopping modules from being installed
🎨 Got tara to display files again 🐛 TODO: solve browsing. Can't double click or use address bar 🎨 Removed /explorer/dir/home route 🎨 Fixed where default dir setting is
|
Now working on #13 |
💄 Finished explorer react component generator 🎨 Started adding address bar 🚑 💄 Fixed a few theme issues due to rewrite 🐛 File shortening need to be implemented
🎨 Started adding navigation 🎨 Added address bar navigation 🎨 Added double click navigation 💄 Fixed explorer styling issues 🐛 Not all files are listed (some dirs such as home dir in Users and Program Files are missing) 🐛 Need to add back and forth button to address bar 🐛 Clicking off address bar to escape does not work 🚑 No apparent breaking navigation issues (app doesn't crash browsing)
🚑 Fixed issue where not all dirs were shown by only displaying index errors, not throw err; 🐛 Files remain selected when chdir() 🐛 Back and forward buttons need implmenting. Can be done with https://github.com/omnidan/redux-undo. PR ready for merger. Will solve back and forth in main branch
…edo-explorer 🎨 Redo explorer for move to webpack 🐛 Still need to add navigation (back and forth buttons), but explorer is (hopefully) faster and the code is easier to understand. 🎨 tara-address-bar is now obsolete.
🎨 Navigation now works, using redux-undo
🎨 Fix off-click issue with address bar 💄 Made position of address bar align correctly 🐛 All that is left is to make right click work and then should be able to merge
🚀 🚑 Fix was to add tara-right-click-menu to plugin config (package.json) 🚑 Closes #15 🎨 Code optimisations (DRY) on plugin-init.ts 🎨 Added explainer comment to plugin finder 🎨 Moved tara-file-operations JSX to TSX for better complication 🎨 Updated file-operations index.ts to use async/await
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After electron-compile stopped working (electron-userland/electron-compile#287), we decided to move to using electron-webpack. After some issues (electron-userland/electron-webpack#83), we managed to get the app running.
Currently working on making packages separate to tara itself as they aren't in the webpack bundle.