Skip to content
This repository has been archived by the owner on Dec 28, 2022. It is now read-only.

Tara-right-click-menu not loading correctly. #15

Closed
Gum-Joe opened this issue Apr 29, 2018 · 2 comments
Closed

Tara-right-click-menu not loading correctly. #15

Gum-Joe opened this issue Apr 29, 2018 · 2 comments

Comments

@Gum-Joe
Copy link
Owner

Gum-Joe commented Apr 29, 2018

Ok. #10 is nearly ready, and the explorer is complete. However, the plugin API is now broken - when loading tara-right-click-menu there is an error, and it appears the plugin API was not loaded correctly.

Thus, this needs to be fixed. Hopefully, a full rework should not be required.

@Gum-Joe
Copy link
Owner Author

Gum-Joe commented May 6, 2018

Correction: Turns out tara-right-click-menu was not in the config file and so was not loaded. Updating issue title to reflect this.

@Gum-Joe Gum-Joe changed the title Plugin API is broken since webpack migration Tara-right-click-menu not loading correctly. May 6, 2018
Gum-Joe added a commit that referenced this issue May 6, 2018
🚀 🚑 Fix was to add tara-right-click-menu to plugin config (package.json)
🚑 Closes #15
🎨 Code optimisations (DRY) on plugin-init.ts
🎨 Added explainer comment to plugin finder
🎨 Moved tara-file-operations JSX to TSX for better complication
🎨 Updated file-operations index.ts to use async/await
@Gum-Joe
Copy link
Owner Author

Gum-Joe commented May 6, 2018

Closed by 853b8f5

@Gum-Joe Gum-Joe closed this as completed May 6, 2018
Gum-Joe added a commit that referenced this issue May 6, 2018
After electron-compile stopped working (electron-userland/electron-compile#287), we decided to move to using electron-webpack. After some issues (electron-userland/electron-webpack#83), we managed to get the app running.

Major changes:
- address-bar is now part of explorer
- Core logic is now in `tara-core`
- Explorer is now less buggy
- Now using electron-webpack instead of electron-compile.

Related Issues & PRs:
#12 
#13 
#14 
#15 

Special thanks to @loopmode for advice & help!
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant