Conversation
[deploy] User / Club / Feed 관련 변경사항 반영
[deploy] User / Notification 수정사항 반영
[deploy] 정산 / 충전 관련 실패 로직 추가
[feat] 피드 / 정산 관련 수정사항 반영
[deploy] 알림 관련 수정사항 반영
[deploy] 리피드 수정사항 반영
[deploy] 프론트 배포 주소 CORS 설정
|
Caution Review failedThe pull request is closed. Walkthrough결제 실패 엔드포인트를 비활성화하고 결제 확인 흐름과 멱등성 기준을 재구성했다. 정산의 사용자 전용 조회는 Settlement 모듈에서 제거되고 User 모듈로 이전되며 DTO/레포지토리 시그니처가 변경되었다. 신규 DTO와 페이지 응답을 추가하고, 내부 월렛 트랜잭션 저장 로직이 도입되었다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant UserController
participant UserService
participant UserSettlementRepository
User->>UserController: GET /users/settlement?page,size,sort
UserController->>UserService: getMySettlementList(pageable)
UserService->>UserSettlementRepository: findMyRecentOrRequested(user, now-10d, pageable)
UserSettlementRepository-->>UserService: Page<MySettlementDto>
UserService-->>UserController: MySettlementResponseDto
UserController-->>User: 200 OK (CommonResponse)
sequenceDiagram
autonumber
actor Client
participant PaymentService
participant TossClient
participant Wallet
participant Repo as PaymentRepository
Client->>PaymentService: confirm(req)
PaymentService->>Repo: findByTossOrderId(req.orderId)
alt Already exists
PaymentService-->>Client: throw ALREADY_COMPLETED_PAYMENT
else New payment
PaymentService->>TossClient: confirmPayment(req)
TossClient-->>PaymentService: TossResponse
PaymentService->>Wallet: create WalletTransaction(+Payment via cascade)
Wallet-->>PaymentService: persisted
PaymentService-->>Client: success
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~40 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (11)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
hotfix로 배포 서버의 버그 수정 사항을 develop에 반영합니다.
📝 요약(Summary)
🛠️ PR 유형
어떤 변경 사항이 있나요?
📸스크린샷 (선택)
💬 공유사항 to 리뷰어
✅ PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.
Summary by CodeRabbit