Update JDK, Gradle and libraries #492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update android-browser-helper to modern SDKs, gradle versions, and dependencies and update code accordingly
orbital17
force-pushed
the
update-projects
branch
from
ecc7ee5 to
72fbba2
Compare
Closed
OlegNitz
approved these changes
Jan 10, 2025
|
|
||
| defaultConfig { | ||
| minSdkVersion 16 | ||
| targetSdkVersion 31 | ||
| minSdkVersion 21 |
There was a problem hiding this comment.
I assume minSdk has raised because targetCompatibility is Java 17. Can we update jdk version that runs gradle, but keep existing build configuration for demos and especially androidbrowserhelper? AFAIK, most of the AndroidX libraries use jdk 1.8, so we should be fine with updating only gradle.
There was a problem hiding this comment.
@orbital17 as I remember these changes would cause bubblewrap update, right?
| versionCode 1 | ||
| versionName VERSION | ||
| targetSdkVersion 35 |
There was a problem hiding this comment.
That's a big jump, are we sure that we covered all changes?
ukaratkevich
requested changes
Jan 10, 2025
|
|
||
| defaultConfig { | ||
| minSdkVersion 16 | ||
| targetSdkVersion 31 | ||
| minSdkVersion 21 |
There was a problem hiding this comment.
@orbital17 as I remember these changes would cause bubblewrap update, right?
|
Closing in favor #493. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.