Update project #491
Closed
Update project #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update android-browser-helper to modern SDKs, gradle versions, and dependencies and update code accordingly
orbital17
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Thank you, Erik, that's amazing work!
I tried to revert the playbilling and also fixed several issues that affected the build in the other PR #492. Please take a look and let me know what you think.
If you need to make some changes, feel free to merge that branch into yours
|
|
||
| implementation fileTree(dir: 'libs', include: ['*.jar']) | ||
| implementation 'com.android.billingclient:billing:6.2.1' | ||
| implementation 'org.chromium.net:cronet-embedded:119.6045.31' | ||
| implementation 'com.android.billingclient:billing:7.1.1' |
There was a problem hiding this comment.
We can't update the play billing library from v6 to v7 yet, as there are other dependencies that need to be considered
|
@orbital17 looks great! I've pulled the other branch and it looks good to me. If you want to merge that one and close this out that's fine with me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update android-browser-helper to modern SDKs, gradle versions, and dependencies and update code accordingly