Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Game Piece Visualization via Maple Sim #169
base: dev
Are you sure you want to change the base?
Add Game Piece Visualization via Maple Sim #169
Changes from 13 commits
69571e8
9c5c72a
abc6e57
15876e6
c38b075
fc227b8
67f2827
d01503e
fefad78
1ce9ab3
343e4be
823d7ba
b8a78be
8bf3e6d
65fcfe6
46af44a
221b5a4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 34 in src/main/kotlin/frc/robot/RobotContainer.kt
Unused symbol
Check warning on line 37 in src/main/kotlin/frc/robot/RobotContainer.kt
Unused symbol
Check warning on line 38 in src/main/kotlin/frc/robot/RobotContainer.kt
Unused symbol
Check warning on line 42 in src/main/kotlin/frc/robot/RobotContainer.kt
Unused symbol
Check warning on line 43 in src/main/kotlin/frc/robot/RobotContainer.kt
Unused symbol
Check warning on line 61 in src/main/kotlin/frc/robot/RobotContainer.kt
Unused symbol
Check warning on line 127 in src/main/kotlin/frc/robot/RobotContainer.kt
Unused symbol
Check warning on line 11 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 14 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 16 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 18 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 20 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 23 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 26 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 29 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 35 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 41 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 44 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 47 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 50 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 52 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 55 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 57 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 59 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 62 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 64 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 66 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 68 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 70 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 72 in src/main/kotlin/frc/robot/lib/GeomExtensionFunctions.kt
Unused symbol
Check warning on line 3 in src/main/kotlin/frc/robot/subsystems/ReefCommands.kt
Unused import directive
Check warning on line 9 in src/main/kotlin/frc/robot/subsystems/ReefCommands.kt
Unused import directive
Check warning on line 10 in src/main/kotlin/frc/robot/subsystems/ReefCommands.kt
Unused import directive
Check notice on line 26 in src/main/kotlin/frc/robot/subsystems/ReefCommands.kt
Lambda argument inside parentheses
Check warning on line 115 in src/main/kotlin/frc/robot/subsystems/ReefCommands.kt
Unused symbol
Check notice on line 55 in src/main/kotlin/frc/robot/subsystems/Visualizer.kt
Private property naming convention
Check notice on line 56 in src/main/kotlin/frc/robot/subsystems/Visualizer.kt
Private property naming convention
Check notice on line 57 in src/main/kotlin/frc/robot/subsystems/Visualizer.kt
Private property naming convention
Check warning on line 78 in src/main/kotlin/frc/robot/subsystems/Visualizer.kt
Unused symbol
Check warning on line 87 in src/main/kotlin/frc/robot/subsystems/Visualizer.kt
Unused symbol
Check warning on line 143 in src/main/kotlin/frc/robot/subsystems/drive/Drive.java
Field may be 'final'
Check warning on line 16 in src/main/kotlin/frc/robot/subsystems/gripper/Gripper.kt
Unused symbol
Check warning on line 32 in src/main/kotlin/frc/robot/subsystems/gripper/Gripper.kt
Unused symbol
Check warning on line 35 in src/main/kotlin/frc/robot/subsystems/gripper/Gripper.kt
Unused symbol
Check warning on line 44 in src/main/kotlin/frc/robot/subsystems/gripper/Gripper.kt
Unused symbol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is not obvious. Is that just making the sensor return true once the rollers rotate?
It's better to have a trigger that'll handle it. Also, add a small debounce (the coral isn't intake'd instantly).
Check warning on line 13 in src/main/kotlin/frc/robot/subsystems/intake/roller/Roller.kt
Unused symbol
Check warning on line 25 in src/main/kotlin/frc/robot/subsystems/intake/roller/Roller.kt
Unused symbol
Check warning on line 28 in src/main/kotlin/frc/robot/subsystems/intake/roller/Roller.kt
Unused symbol
Check warning on line 18 in src/main/kotlin/frc/robot/subsystems/intake/roller/RollerIO.kt
Unused symbol
Check warning on line 28 in src/main/kotlin/frc/robot/subsystems/intake/roller/RollerIOSim.kt
Redundant nullable return type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use triggers here, too.