Draft
Conversation
since these mod aren't likely to ever be part of the pack again it's fine to get rid of them. this is part one
now we implement the new stuff
Dirty implementation, but I don't have an event to listen to and it's getting replaced with UiE so a mixin feels superfluous for something that's going away soon-ish anyway.
the crop stick logic will get removed once the watering can event is implemented correctly.
once the scanner refactor pr is in, I'll add the handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rework isn't a continuation of the old rework started 2 years ago, but a new effort from scratch.
The rework is now somewhat playable. You should be able to just slot it into the latest experimental build of the pack to start testing things!
More info can be found here:
Progress Tracker:
Integration PRs