This repository was archived by the owner on Oct 1, 2025. It is now read-only.
Removing libs, adding dependencies, client language check and commets translation to English#1
Open
mrTeroblaze wants to merge 58 commits intomasterfrom
Open
Conversation
Taskeren
suggested changes
Sep 5, 2025
Taskeren
left a comment
Taskeren
left a comment
There was a problem hiding this comment.
I didn't look into it too much.
Just found something can be improved.
| try { | ||
| FMLInterModComms | ||
| .sendMessage("Waila", "register", "com.teroblaze.gtitemuntranslator.waila.WailaRegister.register"); | ||
| System.out.println("[" + NAME + "] Waila integration registered."); |
| if (commandManager instanceof ServerCommandManager) { | ||
| ((ServerCommandManager) commandManager).registerCommand(new CommandGTIP()); | ||
| System.out.println("[" + NAME + "] /gtip command registered."); | ||
| ((ServerCommandManager) commandManager).registerCommand(new CommandTIPP()); |
There was a problem hiding this comment.
Commands should be registered in FMLServerStartingEvent, using its #registerServerCommand(ICommand).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed jar
s from libs folder Added Gregtech in dependencies Added client language check, so mod wont won't do anything when en_US is selectedTranslated all comments in English.