Skip to content

Conversation

@zhaobin74
Copy link
Contributor

This PR complements GEOS-ESM/GEOS_OceanGridComp#105 to improve the runoff distribution.

@mfmehari, I think OBIO needs to be addressed separately as it also has a DISCHARGE import. I can't do it since I am not running the OBIO model.

cc' @amolod

@zhaobin74 zhaobin74 requested a review from a team as a code owner July 11, 2025 16:29
@zhaobin74 zhaobin74 added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. Contingent - DNA These changes are contingent on other PRs (DNA=do not approve) labels Jul 11, 2025
@mfmehari
Copy link
Contributor

This PR complements GEOS-ESM/GEOS_OceanGridComp#105 to improve the runoff distribution.

@mfmehari, I think OBIO needs to be addressed separately as it also has a DISCHARGE import. I can't do it since I am not running the OBIO model.

cc' @amolod

@zhaobin74, I think if DISCHARGE is imported at OGCM GC level instead of Ocean GC, it will also work for OBIO.

@zhaobin74
Copy link
Contributor Author

This PR complements GEOS-ESM/GEOS_OceanGridComp#105 to improve the runoff distribution.
@mfmehari, I think OBIO needs to be addressed separately as it also has a DISCHARGE import. I can't do it since I am not running the OBIO model.
cc' @amolod

@zhaobin74, I think if DISCHARGE is imported at OGCM GC level instead of Ocean GC, it will also work for OBIO.

@mfmehari, unfortunately OGCM GC 's grid is not tripolar and ExtData does not support. There are two ways to get proper runoff to obio:

  • do not terminate DISCHARGE import of OPBIO and let ExtData fill it, just like Ocean GC. I am not sure if the two DISCHARGE imports (from Ocean and OBIO) are ok.
  • make a connection between OCEAN DISCHARGE export and OBIO DISCHARGE import

@mfmehari
Copy link
Contributor

@zhaobin74 Ah with "OGCM GC 's grid is not tripolar" it won't work. I will have it imported from ExtData from OBIO GC.

@zhaobin74
Copy link
Contributor Author

@zhaobin74 Ah with "OGCM GC 's grid is not tripolar" it won't work. I will have it imported from ExtData from OBIO GC.

Thanks @mfmehari. Please submit another PR for OBIO GC.

@mathomp4 mathomp4 removed the Contingent - DNA These changes are contingent on other PRs (DNA=do not approve) label Jan 6, 2026
@sdrabenh sdrabenh merged commit ec98d1c into develop Jan 6, 2026
11 of 14 checks passed
@sdrabenh sdrabenh deleted the feature/zhaobin74/improve-runoff-distribution branch January 6, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants