Skip to content

Conversation

@zhaobin74
Copy link
Contributor

@zhaobin74 zhaobin74 commented Jul 11, 2025

This PR adds functionality to replace templated string in JRA55-DO's yaml file corresponding to a particular ocean model resolution. This is necessary for GEOS-ESM/GEOSgcm_GridComp#1136

@zhaobin74 zhaobin74 requested a review from a team as a code owner July 11, 2025 16:33
@zhaobin74 zhaobin74 added the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Jul 11, 2025
@zhaobin74
Copy link
Contributor Author

Can we get this PR merged since its dependency is done? Thanks.

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Sep 11, 2025
@mathomp4
Copy link
Member

Can we get this PR merged since its dependency is done? Thanks.

@zhaobin74 It looks like GEOS-ESM/GEOSgcm_GridComp#1136 is not yet in GEOSgcm_GridComp. Is that still a dependency?

@zhaobin74
Copy link
Contributor Author

zhaobin74 commented Sep 11, 2025

Can we get this PR merged since its dependency is done? Thanks.

@zhaobin74 It looks like GEOS-ESM/GEOSgcm_GridComp#1136 is not yet in GEOSgcm_GridComp. Is that still a dependency?

Yes, it is. I thought it is merged along with the one in Ocean GC. @sdrabenh, could you please look into GEOS-ESM/GEOSgcm_GridComp#1136? Thanks.

@sdrabenh sdrabenh removed the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Jan 6, 2026
@sdrabenh sdrabenh merged commit 56f8547 into develop Jan 6, 2026
19 of 20 checks passed
@sdrabenh sdrabenh deleted the feature/zhaobin74/improve-runoff-distribution branch January 6, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants