-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ImageProxy code #270
Conversation
fix #202 Note: breaking changes. Users will have to save their configuration again
Not tested. @Frenzie You are welcome to check if you want to add some auto migration of the former way of storing user preferences (storing at user config top level was never meant to be supported). |
The settings are extremely basic so that doesn't seem very necessary but then again there should probably be some kind of warning about it. |
I am not sure were the warnings should be given, though |
The README seems to have acquired a changelog. Maybe that suffices? There is one other fairly obvious place, but presumably that would require development. |
Would you be able to test that it still work as it should? |
The proxy HTTP setting works, but the proxy HTTPS setting doesn't seem to. |
Please try again |
I don't have anything at hand to test the "proxy unspecified" setting (that should probably be changed to "Proxy unspecified scheme" or something because I had no idea what it was about anymore without looking at the code) but the rest seems to work now. 👍 |
Super. Let's made those changes in another PR. Anyone? |
* ImageProxy: update text for "Update unspecified scheme" See <#270 (comment)>. * URL scheme * add Dutch * Update xExtension-ImageProxy/i18n/fr/ext.php Co-authored-by: Alexandre Alapetite <[email protected]> * Turkish * protocol-relative URL * Update xExtension-ImageProxy/i18n/fr/ext.php Co-authored-by: Alexandre Alapetite <[email protected]> * fix typo * Update xExtension-ImageProxy/i18n/nl/ext.php Co-authored-by: Alexandre Alapetite <[email protected]> --------- Co-authored-by: Alexandre Alapetite <[email protected]>
fix #202
Note: breaking changes. Users will have to save their configuration again