-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImageProxy: update text for "Update unspecified scheme" #272
Conversation
Co-authored-by: Alexandre Alapetite <[email protected]>
Co-authored-by: Alexandre Alapetite <[email protected]>
@@ -5,7 +5,7 @@ | |||
'proxy_url' => 'Proxy-URL', | |||
'scheme_http' => 'HTTP-Proxy', | |||
'scheme_https' => 'HTTPS-Proxy', | |||
'scheme_default' => 'Proxy unspezifiziert', | |||
'scheme_default' => 'Proxy protokoll-relative URL', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Alexandre Alapetite <[email protected]>
While you are at it @Frenzie :
|
I thought you had just changed that the other day? |
No, I changed many other things, but not that :-) |
Hm, it doesn't seem very fixable. See https://stackoverflow.com/questions/11974008/alternative-to-mb-convert-encoding-with-html-entities-charset for a whole load of nothing. This is immediately obviously worse and not at all equivalent: htmlspecialchars_decode(htmlentities($string)) This is also worse in a different manner and utf8_decode is deprecated to boot: $content = htmlspecialchars_decode(utf8_decode(htmlentities($content, ENT_COMPAT, 'UTF-8', false)));
So suggestions welcome, but it looks like that error message is plain nonsense. |
Hm, I take that back. Turns out the xkcd feed was broken by the old version as well, specifically the 8 in |
It doesn't seem to be particularly special. Edit: more discussion https://www.drupal.org/project/smart_trim/issues/3342481 They went with just removing it, but that doesn't work at all. |
See #270 (comment).