Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageProxy: update text for "Update unspecified scheme" #272

Merged
merged 9 commits into from
Jan 15, 2025

Conversation

Frenzie
Copy link
Member

@Frenzie Frenzie commented Jan 14, 2025

@@ -5,7 +5,7 @@
'proxy_url' => 'Proxy-URL',
'scheme_http' => 'HTTP-Proxy',
'scheme_https' => 'HTTPS-Proxy',
'scheme_default' => 'Proxy unspezifiziert',
'scheme_default' => 'Proxy protokoll-relative URL',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alkarex Alkarex merged commit 500238e into FreshRSS:master Jan 15, 2025
1 check passed
@Alkarex
Copy link
Member

Alkarex commented Jan 15, 2025

While you are at it @Frenzie : mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead in /var/www/FreshRSS/extensions/xExtension-ImageProxy/extension.php on line 131

$doc->loadHTML(mb_convert_encoding($content, 'HTML-ENTITIES', 'UTF-8'));

@Frenzie Frenzie deleted the imageproxy-protocol branch January 15, 2025 21:44
@Frenzie
Copy link
Member Author

Frenzie commented Jan 15, 2025

I thought you had just changed that the other day?

@Alkarex
Copy link
Member

Alkarex commented Jan 15, 2025

I thought you had just changed that the other day?

No, I changed many other things, but not that :-)

@Frenzie
Copy link
Member Author

Frenzie commented Jan 15, 2025

Hm, it doesn't seem very fixable. See https://stackoverflow.com/questions/11974008/alternative-to-mb-convert-encoding-with-html-entities-charset for a whole load of nothing.

This is immediately obviously worse and not at all equivalent:

htmlspecialchars_decode(htmlentities($string))

This is also worse in a different manner and utf8_decode is deprecated to boot:

$content = htmlspecialchars_decode(utf8_decode(htmlentities($content, ENT_COMPAT, 'UTF-8', false)));

mb_decode_numericentity is quite obviously also half useless.

So suggestions welcome, but it looks like that error message is plain nonsense.

@Frenzie
Copy link
Member Author

Frenzie commented Jan 15, 2025

Hm, I take that back. Turns out the xkcd feed was broken by the old version as well, specifically the 8 in ²³⁸Umbrella policy. Anyway, it's too late now.

@Frenzie
Copy link
Member Author

Frenzie commented Jan 15, 2025

It doesn't seem to be particularly special.
Screenshot_20250115_231629

Edit: more discussion https://www.drupal.org/project/smart_trim/issues/3342481

They went with just removing it, but that doesn't work at all.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants