Skip to content

fix(freertos): Correct taskRESERVED_TASK_NAME_LENGTH macro definition #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2025
Merged

fix(freertos): Correct taskRESERVED_TASK_NAME_LENGTH macro definition #1241

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5762092
fix(freertos): Correct taskRESERVED_TASK_NAME_LENGTH macro definition
sudeep-mohanty Feb 7, 2025
f70182d
Merge branch 'main' into fix/reserved_task_name_len_define
aggarg Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions tasks.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,16 +156,15 @@
#define configIDLE_TASK_NAME "IDLE"
#endif

/* Reserve space for Core ID and null termination. */
#if ( configNUMBER_OF_CORES > 1 )
/* Reserve space for Core ID and null termination. */
/* Multi-core systems with up to 9 cores require 1 character for core ID and 1 for null termination. */
#if ( configMAX_TASK_NAME_LEN < 2U )
#error Minimum required task name length is 2. Please increase configMAX_TASK_NAME_LEN.
#endif
#define taskRESERVED_TASK_NAME_LENGTH 2U

#elif ( configNUMBER_OF_CORES > 9 )
#warning Please increase taskRESERVED_TASK_NAME_LENGTH. 1 character is insufficient to store the core ID.
#else
#else /* if ( configNUMBER_OF_CORES > 1 ) */
/* Reserve space for null termination. */
#if ( configMAX_TASK_NAME_LEN < 1U )
#error Minimum required task name length is 1. Please increase configMAX_TASK_NAME_LEN.
Expand Down Expand Up @@ -3597,7 +3596,12 @@ static BaseType_t prvCreateIdleTasks( void )
* only one idle task. */
#if ( configNUMBER_OF_CORES > 1 )
{
/* Append the idle task number to the end of the name. */
/* Append the idle task number to the end of the name.
*
* Note: Idle task name index only supports single-character
* core IDs (0-9). If the core ID exceeds 9, the idle task
* name will contain an incorrect ASCII character. This is
* acceptable as the task name is used mainly for debugging. */
cIdleName[ xIdleTaskNameIndex ] = ( char ) ( xCoreID + '0' );
cIdleName[ xIdleTaskNameIndex + 1 ] = '\0';
}
Expand Down