fix(freertos): Correct taskRESERVED_TASK_NAME_LENGTH macro definition

[sudeep-mohanty]

Description

The taskRESERVED_TASK_NAME_LENGTH definition introduced in #1227 is incorrect for the condition configNUMBER_OF_CORES > 9 as it will never be reached due to the overlapping preprocessor condition of configNUMBER_OF_CORES > 1 before it.

This PR updates the removes the preprocessor condition for configNUMBER_OF_CORES > 9 and adds a note during idle task naming about it.

Test Steps

• Set configNUMBER_OF_CORES > 9 and build any port for the FreeRTOS kernel.

Checklist:

• I have tested my changes. No regression in existing tests.
• I have modified and/or added unit-tests to cover the code changes in this Pull Request.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[sudeep-mohanty]

Hi, @kstribrnAmzn @aggarg! A minor correction is needed to the change introduced in #1227. PTAL Thanks!

[sudeep-mohanty]

Test updates for failed CI run here - FreeRTOS/FreeRTOS#1324.

[aggarg]

If we do this, we need to update the task name writing code as well because we only write one character for the core number as of now - https://github.com/FreeRTOS/FreeRTOS-Kernel/blob/main/tasks.c#L3601.

With the current code, the idle task name would contain wrong core number if the number of cores happen to be more than 9. Since task name is just debugging aid, I think it okay as opposed to adding more task name formatting code. What do you think?

[sudeep-mohanty]

If we do this, we need to update the task name writing code as well because we only write one character for the core number as of now - https://github.com/FreeRTOS/FreeRTOS-Kernel/blob/main/tasks.c#L3601.

With the current code, the idle task name would contain wrong core number if the number of cores happen to be more than 9. Since task name is just debugging aid, I think it okay as opposed to adding more task name formatting code. What do you think?

Sure, I agree that avoiding more complex task name formatting for multi-digit core numbers is acceptable. The downside is that the idle task name will contain a "random" ASCII character if the core id exceeds 9. It might be worth considering an update in the future to handle this case if needed. In the meantime, do you think we should add a comment to clarify this limitation and prevent potential confusion?

[aggarg]

In the meantime, do you think we should add a comment to clarify this limitation and prevent potential confusion?

Yes, sure. Would you please do that in this PR ;)

[sudeep-mohanty]

Added a note. PTAL again Thanks!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[kstribrnAmzn]

Thanks for fixing this :) I noticed this soon after when doing some safety certification work and we chose to fix it in the same way - but I hadn't had the chance to upstream this work since I was out.