Skip to content

fix #59 12.2 error when /su rc bukkit #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
InkerBot wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix #59 12.2 error when /su rc bukkit #64

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d29857
fix typo in RPropertyManager
InkerBot Jan 18, 2023
1ac6375
Use ClassObject to support primitives
InkerBot Jan 18, 2023
f00a8ae
Use MethodType to cast primitive type
InkerBot Jan 26, 2023
fe3d8c4
fix checkstyle and build exceptions
InkerBot Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Bukkit/src/main/java/net/frankheijden/serverutils/bukkit/reflection/RDedicatedServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package net.frankheijden.serverutils.bukkit.reflection;

import com.google.common.primitives.Primitives;
import dev.frankheijden.minecraftreflection.ClassObject;
import dev.frankheijden.minecraftreflection.MinecraftReflection;
import dev.frankheijden.minecraftreflection.MinecraftReflectionVersion;
Expand Down Expand Up @@ -124,7 +125,12 @@ public static Object getConfigValue(Object config, String key) {
public static void setConfigValue(Object config, Object console, String getMethod, String setMethod,
String configMethod, String key) {
Object defaultValue = reflection.invoke(console, getMethod);
Object configValue = RPropertyManager.getReflection().invoke(config, configMethod, key, defaultValue);
reflection.invoke(console, setMethod, configValue);
Class<?> defaultValueClass = Primitives.unwrap(defaultValue.getClass());
Object configValue = RPropertyManager.getReflection().invoke(
config,
configMethod,
ClassObject.of(key),
ClassObject.of(defaultValueClass, defaultValue));
reflection.invoke(console, setMethod, ClassObject.of(defaultValueClass, configValue));
}
}
2 changes: 1 addition & 1 deletion Bukkit/src/main/java/net/frankheijden/serverutils/bukkit/reflection/RPropertyManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ public static MinecraftReflection getReflection() {
}

public static Object newInstance(Object options) {
return ROptionSet.getReflection().newInstance(options);
return getReflection().newInstance(options);
}
}