Skip to content

fix #59 12.2 error when /su rc bukkit#64

Open
InkerBot wants to merge 4 commits intoFrankHeijden:masterfrom
InkerBot:fix-59
Open

fix #59 12.2 error when /su rc bukkit#64
InkerBot wants to merge 4 commits intoFrankHeijden:masterfrom
InkerBot:fix-59

Conversation

@InkerBot
Copy link

As normal, newInstance in reflection class should new Instance it self

As normal, newInstance in reflection class should new Instance it self
@InkerBot InkerBot changed the title [WIP] fix #59 [WIP] fix #59 12.2 error when /su rc bukkit Jan 18, 2023
@InkerBot InkerBot changed the title [WIP] fix #59 12.2 error when /su rc bukkit fix #59 12.2 error when /su rc bukkit Jan 18, 2023
@InkerBot
Copy link
Author

I think, new method likes
Ldev/frankheijden/minecraftreflection/Reflection;invoke(Ljava/lang/Object;Ljava/lang/String;[Ldev/frankheijden/minecraftreflection/ClassObject;)Ljava/lang/Object; but return Ldev/frankheijden/minecraftreflection/ClassObject; maybe better choice

Copy link
Owner

@FrankHeijden FrankHeijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small thingee!

InkerBot and others added 2 commits January 26, 2023 10:09
Co-authored-by: Frank van der Heijden <frank.boekanier@gmail.com>
@InkerBot InkerBot requested a review from FrankHeijden January 26, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments