Add overflow-clip regression test for DefaultEmojiPickerView (#256) - #267
Merged
Conversation
Salvaged from #265. The ClipRect fix itself already landed on master via #259; this adds the missing regression test that constrains the picker below its natural height and asserts the view Column is wrapped in a ClipRect so the overflow is clipped. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvages the widget test from #265.
The
ClipRectproduction fix for #256 already landed onmastervia #259, which made #265's code change redundant (and conflicting). The one genuinely-new piece there was a regression test — this PR carries just that test over on top of currentmaster.The test constrains the picker well below its natural height and asserts the view
Columnis wrapped in aClipRect(matched precisely via a widget predicate so it isn't affected by the incidentalClipRects the grid/scroll views add).All tests pass locally (
flutter test).Closes the coverage gap left by #265.