Clip overflow in DefaultEmojiPickerView with ClipRect (#256) - #265
Closed
Fintasys wants to merge 2 commits into
Closed
Clip overflow in DefaultEmojiPickerView with ClipRect (#256)#265Fintasys wants to merge 2 commits into
Fintasys wants to merge 2 commits into
Conversation
Column (a Flex) does not accept a clipBehavior parameter, so flutter analyze failed with undefined_named_parameter. Wrap the inner Column in a ClipRect to clip overflowing children when a parent constrains the picker tighter than its natural height (#256). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FR5kaTA7MWRLWGmTvcN8BG
Verifies the inner Column is wrapped in a ClipRect so overflow is clipped when the picker is constrained tighter than its natural height (#256). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FR5kaTA7MWRLWGmTvcN8BG
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #259, which failed CI because it passed
clipBehavior: Clip.hardEdgetoColumn.Columnis aFlexand has noclipBehaviorparameter, soflutter analyzeerrored withundefined_named_parameter.This wraps the inner
Columnin aClipRectinstead, achieving the same goal with a valid API: overflow paint is clipped to the picker's bounds when a parent constrains it tighter than the natural sum of the category bar, emoji view, and bottom action bar (#256).🤖 Generated with Claude Code
Generated by Claude Code