Skip to content

fix: sanitize dynamic completion values #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Finesssee wants to merge 1 commit into from
Closed

fix: sanitize dynamic completion values #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 33 additions & 6 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1519,6 +1519,21 @@ mod tests {
"outer pipe should receive stdout after restoration, got: {outer_output:?}"
);
}

#[test]
fn test_sanitize_completion_value_strips_shell_metacharacters() {
let value = "$(touch /tmp/pwn); hello|world && rm -rf /";
assert_eq!(
sanitize_completion_value(value),
"touch /tmp/pwn helloworld rm -rf /"
);
}

#[test]
fn test_sanitize_completion_value_keeps_common_identifiers() {
let value = "LIN-123 team_alpha/user@example.com";
assert_eq!(sanitize_completion_value(value), value);
}
}

fn sanitize_completion_field(value: &str) -> String {
Expand All @@ -1533,6 +1548,18 @@ fn sanitize_completion_field(value: &str) -> String {
.to_string()
}

fn sanitize_completion_value(value: &str) -> String {
sanitize_completion_field(value)
.chars()
.filter(|ch| {
ch.is_ascii_alphanumeric()
|| matches!(ch, ' ' | '.' | '_' | '-' | ':' | '/' | '@' | '+')
})
.collect::<String>()
.trim()
.to_string()
}

/// Handle the context command - detect current Linear issue from git branch
async fn handle_context(
output: &OutputOptions,
Expand Down Expand Up @@ -1919,7 +1946,7 @@ async fn complete_teams(cache: Option<&cache::Cache>, prefix: &str) -> Result<()
{
println!(
"{}\t{}",
sanitize_completion_field(key),
sanitize_completion_value(key),
sanitize_completion_field(name)
);
}
Expand All @@ -1945,7 +1972,7 @@ async fn complete_projects(cache: Option<&cache::Cache>, prefix: &str) -> Result
if prefix.is_empty() || name.to_lowercase().starts_with(&prefix_lower) {
println!(
"{}\t{}",
sanitize_completion_field(name),
sanitize_completion_value(name),
sanitize_completion_field(state)
);
}
Expand Down Expand Up @@ -1991,7 +2018,7 @@ async fn complete_issues(prefix: &str) -> Result<()> {
if prefix.is_empty() || id.to_uppercase().starts_with(&prefix_upper) {
println!(
"{}\t{}",
sanitize_completion_field(id),
sanitize_completion_value(id),
sanitize_completion_field(title)
);
}
Expand Down Expand Up @@ -2081,7 +2108,7 @@ async fn complete_statuses(
if prefix.is_empty() || name.to_lowercase().starts_with(&prefix_lower) {
println!(
"{}\t{}",
sanitize_completion_field(name),
sanitize_completion_value(name),
sanitize_completion_field(type_)
);
}
Expand Down Expand Up @@ -2111,7 +2138,7 @@ async fn complete_users(cache: Option<&cache::Cache>, prefix: &str) -> Result<()
{
println!(
"{}\t{}",
sanitize_completion_field(display),
sanitize_completion_value(display),
sanitize_completion_field(name)
);
}
Expand All @@ -2137,7 +2164,7 @@ async fn complete_labels(cache: Option<&cache::Cache>, prefix: &str) -> Result<(
if prefix.is_empty() || name.to_lowercase().starts_with(&prefix_lower) {
println!(
"{}\t{}",
sanitize_completion_field(name),
sanitize_completion_value(name),
sanitize_completion_field(color)
);
}
Expand Down
Loading