fix: sanitize dynamic completion values#21
Closed
Finesssee wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
This change is already on master as c91cbd5 () and shipped in v0.3.19, so I’m closing this PR as already landed. |
Owner
Author
|
Closing because this exact change is already on master in c91cbd5 and released in v0.3.19. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
compgen/substitution).Description
sanitize_completion_valuefunction that trims control whitespace and allowlists safe characters for insertion into shell completions.sanitize_completion_valuefor the completion "value" field emitted forteams,projects,issues,statuses,users, andlabels, while keeping description sanitization intact.LIN-123, emails, slashes) are preserved.Testing
cargo test test_sanitize_completion_value -- --nocaptureand the new tests passed.cargo fmtto format changes successfully.Codex Task