overriding with inheritance from overridden#15521
Open
EugenPolyakov wants to merge 1 commit intoFakeFishGames:masterfrom
Open
overriding with inheritance from overridden#15521EugenPolyakov wants to merge 1 commit intoFakeFishGames:masterfrom
EugenPolyakov wants to merge 1 commit intoFakeFishGames:masterfrom
Conversation
Collaborator
|
Thank you for the PR! It's worth noting that there's another PR that implements this, although it has been in the works since 2022 and is still a work in progress. This seems like a vastly simpler implementation though - which makes me wonder if there are some edge cases that aren't taken into account here that would need more complex logic to solve. I don't have time to do a proper review on this right now, but I'll look into it in the future and try to think of potential edge cases or issues in the chosen approach though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow overriding with inheritance from overridden.
Know issues: