Kill characters before removing them with status effects#15280
Open
TheNinjaScout wants to merge 1 commit intoFakeFishGames:masterfrom
Open
Kill characters before removing them with status effects#15280TheNinjaScout wants to merge 1 commit intoFakeFishGames:masterfrom
TheNinjaScout wants to merge 1 commit intoFakeFishGames:masterfrom
Conversation
Adds a new character boolean property called TriggerDeathEffects (set to true by default) which prevents the character from triggering "OnDeath" type status effects as well as death sounds and the multiplayer chat notification when they die, if set to false, essentially resulting in a silent death. This is synced between the server and the clients in order to fully work in multiplayer as it does in singleplayer. When characters are removed through status effects, we now set this new property to false, as well as kill them before removing them, making removing characters work just like it did before, with the added benefit of counting them as dead, fixing various issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15279
Adds a new character boolean property called TriggerDeathEffects (set to true by default) which prevents the character from triggering "OnDeath" type status effects as well as death sounds and the multiplayer chat notification when they die, if set to false, essentially resulting in a silent death. This is synced between the server and the clients in order to fully work in multiplayer as it does in singleplayer.
When characters are removed through status effects, we now set this new property to false, as well as kill them before removing them, making removing characters work just like it did before, with the added benefit of counting them as dead, fixing various issues.