Networking Guide #249
Draft
Networking Guide #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
IMB11
added
new-content
IMB11
requested changes
Dec 31, 2024
.../java/com/example/docs/networking/basic/FabricDocsReferenceNetworkingBasicDataGenerator.java
Outdated
Show resolved
Hide resolved
Octol1ttle
suggested changes
Dec 31, 2024
|
|
||
| @[code lang=java transcludeWith=::use_poisonous_potato_payload](@/reference/latest/src/main/java/com/example/docs/networking/basic/UsePoisonousPotatoPayload.java) | ||
|
|
||
| Note the usage of `PacketCodec.tuple` to combine two values, a `String` and a `BlockPos`. |
There was a problem hiding this comment.
I know this is done for the sake of example, but this example is inefficient and dangerous:
- Sending any data about the player is pointless because the server already knows which player sent it and can access any information it needs there.
- If the client or server want to refer to another entity in a packet, they should use it's numerical ID (not UUID)
- A malicious client can exploit this because the server doesn't check that any data is factually correct (data validation in C2S packets is also an important topic).
There was a problem hiding this comment.
- Yes, this I figured. I wanted a simple example.
- I believe we can overlook this for the sake of simplicity.
- This however is concerning. I was not aware and didn't think that far as we're dealing with the basics. I'm open for a better example that could address above 2 points as well.
There was a problem hiding this comment.
If I were to write this, I would add a situation where a player is casting some sort of spell to another entity. In this situation, efficient networking can be showcased (see 2) and proper data validation can be showcased with checks like "does the entity actually exist and is not invulnerable?" "is the player close enough to the entity?"
- remove dedicated data generator - add lightning tater item model generator to the shared pack - fix offset line numbers - fix broken link in damage types doc
dicedpixels
force-pushed
the
networking
branch
from
14472b6 to
0e99dc2
Compare
- add more info about `PlayerLookup` and adjust the code - limt the `UseItemCallback` to the logical client
Octol1ttle
suggested changes
Jan 1, 2025
...src/client/java/com/example/docs/network/basic/FabricDocsReferenceNetworkingBasicClient.java
Outdated
Show resolved
Hide resolved
reference/latest/src/main/java/com/example/docs/networking/basic/LightningTaterItem.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports Networking.
Differences:
Note: PR is marked as draft till docs are updated to 1.21.4. Feel free to review till then.