Networking Guide #249

dicedpixels · 2024-12-31T12:14:33Z

Differences:

Actual working item, Lightning Tater.
Along with S2C, a C2S example is also included.

netlify · 2024-12-31T12:14:49Z

✅ Deploy Preview for nimble-elf-d9d491 ready!

Name	Link
🔨 Latest commit	`7d13374`
🔍 Latest deploy log	https://app.netlify.com/sites/nimble-elf-d9d491/deploys/67cb213557e42c000802994b
😎 Deploy Preview	https://deploy-preview-249--nimble-elf-d9d491.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

reference/latest/src/main/resources/fabric.mod.json

.../java/com/example/docs/networking/basic/FabricDocsReferenceNetworkingBasicDataGenerator.java

develop/networking.md

...src/client/java/com/example/docs/network/basic/FabricDocsReferenceNetworkingBasicClient.java

reference/latest/src/main/java/com/example/docs/networking/basic/LightningTaterItem.java

develop/networking.md

IMB11 · 2025-01-15T15:20:34Z

Hi! The documentation has been updated to version 1.21.4. Please rebase your PR and update your code to align with the latest version.

Alternatively, you can create a new branch based on the latest commit from the FabricMC:main branch, copy over your changes from the old dicedpixels:networking branch, update it, and open a new PR - this approach is often simpler than dealing with complex git commands if you're not the best git wrangler.

Once you've completed the updates and are confident everything is ready, feel free to unmark this as a draft. Thanks again for your contribution!

its-miroma · 2025-02-26T14:52:22Z

Hello @dicedpixels, are you still working on this?

- remove dedicated data generator - add lightning tater item model generator to the shared pack - fix offset line numbers - fix broken link in damage types doc

- add more info about `PlayerLookup` and adjust the code - limt the `UseItemCallback` to the logical client

- attempted to improve the c2s section to align with review comments

dicedpixels · 2025-02-26T15:29:36Z

Hello @dicedpixels, are you still working on this?

I guess so 😅. Haven't had time to sit and look back at it. I believe I've addressed all the comments, PR should be up-to-date. I will undraft it so more people can review.

develop/data-generation/loot-tables.md

develop/networking.md

public/assets/develop/networking/sides.png

develop/networking.md

...src/client/java/com/example/docs/network/basic/FabricDocsReferenceNetworkingBasicClient.java

...test/src/main/java/com/example/docs/networking/basic/FabricDocsReferenceNetworkingBasic.java

IMB11

Very good quality page! Well done. Just a very minor nitpick and then LGTM I think!

develop/networking.md

...src/client/java/com/example/docs/network/basic/FabricDocsReferenceNetworkingBasicClient.java

develop/networking.md

its-miroma · 2025-03-07T16:37:39Z

still not convinced with the diagram being an image, but there's not much to do about it

not applicable (the example is intentionally wrong and as such can't be in the mod)

modmuss50 · 2025-03-07T16:45:31Z

develop/networking.md

+Upon testing, you will see a lightning bolt being summoned and nothing crashes. Now you want to show the mod to your
+friend, you boot up a dedicated server and invite your friend on with the mod installed.
+
+You use the item and the server crashes. You will probably notice in the crash log an error similar to this:
+
+```log
+[Server thread/FATAL]: Error executing task on Server
+java.lang.RuntimeException: Cannot load class net.minecraft.client.MinecraftClient in environment type SERVER
+```
+
+### Why Does the Server Crash? {#why-does-the-server-crash}
+
+The code calls logic only present on the client distribution of the Minecraft. The reason for Mojang distributing the
+game in this way is to cut down on the size of the Minecraft Server JAR file. There isn't really a reason to include an
+entire rendering engine when your own machine will render the world.
+
+In a development environment, client-only classes are indicated by the `@Environment(EnvType.CLIENT)` annotation.
+
+### How Do We Fix the Crash? {#how-do-we-fix-the-crash}
+
+To fix this issue, you need to understand how the game client and dedicated server communicate:
+
+![Sides](/assets/develop/networking/sides.png)
+
+The diagram above shows that the game client and dedicated server are separate systems, bridged together using
+_packets_. Packets can contain data which we refer to as the _payload_.


This is fine I guess, it just doenst have anything to do with networking. Packets are still sent between the logicial client and server even in single player, or when on a LAN world. A better example would be to cause desync by setting something only the logicial client. Maybe try adding a block to the hotbar from a keybind or something.

IMB11 added new-content A new page or set of pages stage:verification This should be verified labels Dec 31, 2024

IMB11 requested changes Dec 31, 2024

View reviewed changes

reference/latest/src/main/resources/fabric.mod.json Outdated Show resolved Hide resolved

.../java/com/example/docs/networking/basic/FabricDocsReferenceNetworkingBasicDataGenerator.java Outdated Show resolved Hide resolved

Octol1ttle suggested changes Dec 31, 2024

View reviewed changes

develop/networking.md Outdated Show resolved Hide resolved

develop/networking.md Outdated Show resolved Hide resolved

develop/networking.md Outdated Show resolved Hide resolved

develop/networking.md Outdated Show resolved Hide resolved

dicedpixels force-pushed the networking branch from 14472b6 to 0e99dc2 Compare December 31, 2024 13:51

Octol1ttle suggested changes Jan 1, 2025

View reviewed changes

dicedpixels force-pushed the networking branch from 2a3708b to 4b11494 Compare January 17, 2025 16:36

its-miroma added stage:expansion This should be expanded and removed stage:verification This should be verified labels Jan 18, 2025

its-miroma mentioned this pull request Jan 29, 2025

Developer Guides #6

Open

30 tasks

dicedpixels added 9 commits February 26, 2025 20:40

initial port of the networking tutorial

99f5d52

implement review comments:

c2279b2

- remove dedicated data generator - add lightning tater item model generator to the shared pack - fix offset line numbers - fix broken link in damage types doc

implement more review comments:

8c2ca23

- add more info about `PlayerLookup` and adjust the code - limt the `UseItemCallback` to the logical client

addressing another set of review comments

f73d8c2

- update code for 1.21.4

3558a67

- attempted to improve the c2s section to align with review comments

update example videos

a5eb921

fix off set transclude

0a31c2a

add sidebar entries

a47412c

revert change in damage-types

d2edbef

dicedpixels force-pushed the networking branch from 2140ab1 to d2edbef Compare February 26, 2025 15:24

fix markdown lint issue

a0b89d3

dicedpixels marked this pull request as ready for review February 26, 2025 15:29

dicedpixels requested a review from a team as a code owner February 26, 2025 15:29

its-miroma added stage:verification This should be verified and removed stage:expansion This should be expanded labels Feb 26, 2025

run datagen, fix fabric.mod.json formatting

a3ea5db

its-miroma requested changes Feb 28, 2025

View reviewed changes

changes from review comments

13a1e92

its-miroma requested changes Mar 5, 2025

View reviewed changes

develop/networking.md Outdated Show resolved Hide resolved

develop/networking.md Outdated Show resolved Hide resolved

its-miroma requested a review from Octol1ttle March 5, 2025 10:11

more review comments

8fe2124

Octol1ttle suggested changes Mar 5, 2025

View reviewed changes

more and more review comments addressed

257998c

dicedpixels requested review from Octol1ttle and its-miroma March 5, 2025 15:40

IMB11 previously requested changes Mar 5, 2025

View reviewed changes

develop/networking.md Show resolved Hide resolved

its-miroma previously approved these changes Mar 7, 2025

View reviewed changes

Octol1ttle suggested changes Mar 7, 2025

View reviewed changes

develop/networking.md Outdated Show resolved Hide resolved

develop/networking.md Outdated Show resolved Hide resolved

develop/networking.md Outdated Show resolved Hide resolved

develop/networking.md Outdated Show resolved Hide resolved

develop/networking.md Outdated Show resolved Hide resolved

more, more and more review comments addressed

1febf2e

dicedpixels dismissed its-miroma’s stale review via 1febf2e March 7, 2025 15:14

fix markdown lint issue

9e166fa

dicedpixels requested review from its-miroma and Octol1ttle March 7, 2025 15:15

Octol1ttle suggested changes Mar 7, 2025

View reviewed changes

fix field order, misc writing changes, add a living entity check

84afa18

Octol1ttle approved these changes Mar 7, 2025

View reviewed changes

its-miroma requested changes Mar 7, 2025

View reviewed changes

develop/networking.md Outdated Show resolved Hide resolved

develop/networking.md Show resolved Hide resolved

adjust authors

7d13374

its-miroma added stage:ready This is ready to be merged and removed stage:verification This should be verified labels Mar 7, 2025

its-miroma approved these changes Mar 7, 2025

View reviewed changes

modmuss50 reviewed Mar 7, 2025

View reviewed changes

its-miroma merged commit daff204 into FabricMC:main Mar 7, 2025
7 checks passed

ArisuwuMei mentioned this pull request May 31, 2025

Correct transclusion #336

Merged

Networking Guide #249

Networking Guide #249

Uh oh!

Conversation

dicedpixels commented Dec 31, 2024 • edited by its-miroma Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Dec 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for nimble-elf-d9d491 ready!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IMB11 commented Jan 15, 2025

Uh oh!

its-miroma commented Feb 26, 2025

Uh oh!

dicedpixels commented Feb 26, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IMB11 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

its-miroma commented Mar 7, 2025

Uh oh!

modmuss50 Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dicedpixels commented Dec 31, 2024 •

edited by its-miroma

Loading

netlify bot commented Dec 31, 2024 •

edited

Loading

IMB11 left a comment •

edited

Loading