Various fixes

.gitignore

@@ -2,3 +2,5 @@ node_modules
 npm-debug.log
 .env
 coverage
+.vscode
+package-lock.json

index.js

@@ -143,7 +143,7 @@ Request.prototype.abort = function () {
 };
 
 // expose request methods from RequestRetry
-['end', 'on', 'emit', 'once', 'setMaxListeners', 'start', 'removeListener', 'pipe', 'write'].forEach(function (requestMethod) {
+['end', 'on', 'emit', 'once', 'setMaxListeners', 'start', 'removeListener', 'pipe', 'write', 'auth'].forEach(function (requestMethod) {
   Request.prototype[requestMethod] = function exposedRequestMethod () {
     return this._req[requestMethod].apply(this._req, arguments);
   };
@@ -216,6 +216,10 @@ function defaults(defaultOptions, defaultF) {
   });
   factory.del = factory['delete'];
 
+  ['jar', 'cookie'].forEach(function (method) {
+    factory[method] = factory.Request.request[method];
+  });
+
   return factory;
 }
 
@@ -230,3 +234,7 @@ Factory.RetryStrategies = RetryStrategies;
   makeHelper(Factory, verb);
 });
 Factory.del = Factory['delete'];
+
+['jar', 'cookie'].forEach(function (method) {
+  Factory[method] = Factory.Request.request[method];
+});

test/auth.test.js

@@ -0,0 +1,18 @@
+'use strict';
+
+var request = require('../');
+var t = require('chai').assert;
+
+describe('Auth', function () {
+    it('should work with Basic Authentication', function (done) {
+        var r = request.defaults({
+            json: true
+        });
+        r('http://httpbin.org/basic-auth/user/passwd', function (err, response, body) {
+            t.strictEqual(response.statusCode, 200);
+            t.strictEqual(body.authenticated, true);
+            t.strictEqual(body.user, 'user');
+            done();
+        }).auth('user', 'passwd', false);
+    });
+});

test/cookie.test.js

@@ -0,0 +1,23 @@
+'use strict';
+
+var request = require('../');
+var t = require('chai').assert;
+
+describe('Cookie', function () {
+    it('should work with custom cookie jar', function (done) {
+        const j = request.jar();
+        var url = 'http://httpbin.org/cookies/set?k2=v2&k1=v1';
+        request({
+            url,
+            jar: j,
+            json: true
+        }, function (err, response, body) {
+            t.strictEqual(response.statusCode, 200);
+            var cookies = j.getCookies(url);
+            t.strictEqual(cookies.length, 2);
+            t.strictEqual(cookies.filter(c => c.key === 'k1')[0].value, 'v1');
+            t.strictEqual(cookies.filter(c => c.key === 'k2')[0].value, 'v2');
+            done();
+        });
+    });
+});

test/defaults.test.js

@@ -11,15 +11,15 @@ describe('Defaults', function () {
     });
     r('http://www.filltext.com/?rows=1', function (err, response, body) {
       t.strictEqual(response.statusCode, 200);
-      t.strictEqual(body[0].d, 1);
+      t.isNumber(body[0].d);
       done();
     });
   });
 
   it('should set a default function', function (done) {
     var r = request.defaults({}, function (err, response, body) {
       t.strictEqual(response.statusCode, 200);
-      t.strictEqual(body[0].d, 1);
+      t.isNumber(body[0].d);
       done();
     });
     r({ url: 'http://www.filltext.com/?rows=1&d={index}', json: true });
@@ -32,7 +32,7 @@ describe('Defaults', function () {
     });
     r.get({ url: 'http://www.filltext.com/?rows=1', qs: { d: "{index}" } }, function (err, response, body) {
       t.strictEqual(response.statusCode, 200);
-      t.strictEqual(body[0].d, 1);
+      t.isNumber(body[0].d);
       done();
     });
   });
@@ -49,7 +49,7 @@ describe('Defaults', function () {
         fullResponse: false
     });
     level2.get('/?rows=1').then(function (body) {
-      t.strictEqual(body[0].d, 1);
+      t.isNumber(body[0].d);
       done();
     });
   });
@@ -61,10 +61,10 @@ describe('Defaults', function () {
     });
     r({ url: 'http://www.filltext.com/?rows=1', qs: { x: "test" } }, function (err, response, body) {
       t.strictEqual(response.statusCode, 200);
-      t.strictEqual(body[0].d, 1);
+      t.isNumber(body[0].d);
       t.strictEqual(body[0].x, "test");
       done();
     });
   });
 
-});
+});

test/helpers.js

@@ -94,4 +94,4 @@ describe('Helpers', function () {
     }
   });
 
-});
+});