Various fixes #60
Merged
Various fixes #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGRibreau
reviewed
Jul 26, 2017
test/various.test.js
Outdated
| var t = require('chai').assert; | ||
|
|
||
| describe('Various', function () { | ||
| it('should work with Basic Authentication', function (done) { |
There was a problem hiding this comment.
could we split this file in two, one for "test/auth.test.js" another one for "test/cookie.test.js" ?
There was a problem hiding this comment.
Fixed in latest commit
FGRibreau
reviewed
Jul 26, 2017
| @@ -11,15 +11,15 @@ describe('Defaults', function () { | |||
| }); | |||
| r('http://www.filltext.com/?rows=1', function (err, response, body) { | |||
| t.strictEqual(response.statusCode, 200); | |||
| t.strictEqual(body[0].d, 1); | |||
| t.isNumber(body[0].d); | |||
There was a problem hiding this comment.
Hum, why not. I prefer to ensure that the response is as it should be (because it's free here to do so), why would we want to prefer isNumber here?
There was a problem hiding this comment.
As mentioned in PR comment, filltext.com does not return 1 but a random integer, e.g. try running
curl http://www.filltext.com/?rows=1&d=indexFor me, it returns 17120, so the strictEqual tests were failing. I replaced them with isNumber so that they pass.
|
Released in v1.12.2, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this great library! I have provided fixes for #52 and #46, provided relevant tests and also fixed some tests since filltext.com does not return 1 as the first ID any more.