Repr improvement #6597
Open
Repr improvement #6597
+217
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update repr.lua
Reimplements something similar to the old repr: https://github.com/FAForever/fa/blob/5df582851a64ac8cc7545dab243ec6935c495605/lua/system/repr.lua
lL1l1
force-pushed
the
repr-improvement
branch
4 times, most recently
from
72c4aed to
47aac38
Compare
lL1l1
force-pushed
the
repr-improvement
branch
from
47aac38 to
ee451ba
Compare
|
@maudlin27 / @relent0r you both use this function too. It may be interesting for you to look at these changes and share your thoughts. |
4z0t
requested changes
Dec 26, 2024
lua/system/repr.lua
Outdated
| local gsub = string.gsub | ||
| local fmt = string.format | ||
| local _rawget = rawget | ||
| local type = type | ||
| local getmetatable = getmetatable |
There was a problem hiding this comment.
Like this diversity in variable naming. It was discussed 3 years ago and we still mix this and that.
There was a problem hiding this comment.
Do you have a link to the discussion? I haven't seen it.
lua/system/repr.lua
Outdated
| } | ||
|
|
||
| ---@param v table | fa-class | fa-class-state | ||
| local function fafTableToString(v) |
There was a problem hiding this comment.
ObjectToString sounds more reasonable.
4z0t
requested changes
Dec 27, 2024
lua/system/repr.lua
Outdated
| local type = type | ||
| local getmetatable = getmetatable | ||
| local debugGetInfo = debug.getinfo |
There was a problem hiding this comment.
If you make upvalued functions of certain libraries as Pascal case then follow it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
More FAF-specific improvements to the inspect library:
__indexfields if they're the same as the table. This removes a lot of common recursive clutter (it is still possible to recurse, for example theBrain.CDR.BrainorWorldView.view.WorldViewin the example below).Testing done on the proposed changes
Use this command on a Percival:
Example Output (Percival).txt
Use this command:
Example Output (main WorldView).txt
Additional context
The last version of the original repr printed class-specific data. I was lazy on implementing that, but it could be done by using a helper function instead of directly the names table. Still, in general these changes lay the foundations for class-specific data printing.
Checklist