Skip to content

fix: change language #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chadbrokaw merged 2 commits into from
Sep 30, 2025
Merged

fix: change language #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8220007
fix: change language
chadbrokaw Sep 30, 2025
67b44e7
test: fix test
chadbrokaw Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/pages/EventDetailPage/EventDetailPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ it("displays every page section and table row", async () => {
[
"About",
"Details",
"Registration",
"Additional Information",
"Tags",
"Date & Time",
"Event Link",
"View Details",
"Categories",
"Eligibilities",
"Age Group",
Expand Down
36 changes: 18 additions & 18 deletions app/pages/EventDetailPage/EventDetailPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export const EventDetailPage = () => {

const registrationRows = [
{
title: "Event Link",
title: "View Details",
value: data.registration_link?.url ? (
<a
href={data.registration_link.url}
Expand All @@ -83,9 +83,7 @@ export const EventDetailPage = () => {
>
{data.registration_link.url}
</a>
) : (
"No registration link available"
),
) : null,
},
];

Expand Down Expand Up @@ -156,20 +154,22 @@ export const EventDetailPage = () => {
/>
</DetailInfoSection>

<DetailInfoSection
title="Registration"
data-testid="eventdetailpage-detailinfosection"
>
<InfoTable<{ title: string; value: ReactNode }>
rowRenderer={(detail) => (
<tr key={detail.title}>
<th>{detail.title}</th>
<td>{detail.value}</td>
</tr>
)}
rows={registrationRows}
/>
</DetailInfoSection>
{data.registration_link?.url && (
<DetailInfoSection
title="Additional Information"
data-testid="eventdetailpage-detailinfosection"
>
<InfoTable<{ title: string; value: ReactNode }>
rowRenderer={(detail) => (
<tr key={detail.title}>
<th>{detail.title}</th>
<td>{detail.value}</td>
</tr>
)}
rows={registrationRows}
/>
</DetailInfoSection>
)}
<DetailInfoSection
title="Tags"
borderBottom={false}
Expand Down
2 changes: 1 addition & 1 deletion app/pages/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export const CATEGORIES: Readonly<ServiceCategory[]> = [
{
algoliaCategoryName: "Education",
id: "358",
name: "Education",
name: "Education, After School, & Summer Programs",
slug: "education",
steps: ["subcategories", "results"],
subcategorySubheading: defaultSubheading,
Expand Down
8 changes: 8 additions & 0 deletions test/fixtures/EventsData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ export const EVENTS_DATA = [
{
data: {
id: 67,
registration_link: {
url: "https://www.our415.org",
},
attributes: {
title: "Back to School Conference",
createdAt: "2024-07-22T23:54:56.662Z",
Expand Down Expand Up @@ -1404,6 +1407,11 @@ export const createFormattedEventData = (): ReturnType<
typeof useEventData
>["data"] => ({
...EVENTS_DATA[0].data.attributes,
registration_link: {
id: EVENTS_DATA[0].data.id,
text: "Register",
url: EVENTS_DATA[0].data.registration_link?.url || "",
},
id: 10,
categories: [{ id: 11111, label: "Fake Label" }],
eligibilities: [{ id: 11111, label: "Fake Label" }],
Expand Down
Loading