Skip to content

Conversation

@chadbrokaw
Copy link
Collaborator

This pull request updates the event detail page to improve how registration information is displayed and clarifies category naming. The most significant changes are the renaming of the "Event Link" to "View Details," conditional rendering of registration details, and an updated category name for clarity.

Event Registration Section Improvements:

  • Changed the label from "Event Link" to "View Details" in both the UI and the test to better reflect the purpose of the link. [1] [2]
  • Updated the registration link row to render nothing if there is no link, instead of displaying "No registration link available."
  • Modified the display logic so the registration section is only shown if a registration link exists, and updated the section title from "Registration" to "Additional Information." [1] [2]

Category Naming Clarification:

  • Updated the "Education" category name to "Education, After School, & Summer Programs" for improved clarity in the category list.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request improves the event detail page display by updating language and making registration information conditional. The changes focus on clearer labeling and only showing registration sections when relevant data exists.

  • Updated "Event Link" label to "View Details" for better clarity
  • Made registration section conditional on the presence of a registration link
  • Renamed "Education" category to "Education, After School, & Summer Programs"

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
app/pages/constants.ts Updated category name for education services
app/pages/EventDetailPage/EventDetailPage.tsx Improved registration section display logic and labeling
app/pages/EventDetailPage/EventDetailPage.test.tsx Updated test to reflect new "View Details" label

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@chadbrokaw chadbrokaw merged commit 772916b into main Sep 30, 2025
1 check passed
chadbrokaw added a commit that referenced this pull request Oct 15, 2025
* fix: change language

* test: fix test
chadbrokaw added a commit that referenced this pull request Oct 17, 2025
* map exploration, hide expired events, fix weback

* Temporarily disable tests

* Revert webpack change

* Improve Search Header

* fix: fix tests and cleanup code

* reenable tests

* refactor: remove unused zoom change listener from SearchMap component

* fix: Fix BrowseResultsPage

* fix: add some logging

* fix: remove console log

* attempt to fix category switching issue

* Don't reset map init

* fix: remove logging

* Pulling events from Open Data Portal

* fix: add days of week and allow for series of events

* fix: refresh styles

* fix: test

* fix: remove exploration work for eligibility filtering

* fix: Fix some visual inconsistencies and bugs

* rename featued events and shuffle homepage order

* fix: calendar section background color

* Remove commented code

* fix: ensure https protocol

* fix: make it more robust and add security considerations

* fix: split apart the calendar

* Use React-GTM-Module

Add typing for react-gtm-module

fix: temporarily deploy Google Analytics to staging

fix: add temporary logging

fix: remove GA4 logging

* fix: add error boundary and remove GA from development

* fix: Page not found

* fix: Rearrange featured resources and the calendar

* Review

* fix: comment

* Eligibility filtering for senior services

* fix: change language (#355)

* fix: change language

* test: fix test

* fix: limit featured resources to first four

* fix: event details page

* feat: Rework events calendar for agenda view

* fix: correct featured events navigation

* test: fix test

* fix: lint

* code review

* fix: z-index issue
chadbrokaw added a commit that referenced this pull request Oct 20, 2025
* map exploration, hide expired events, fix weback

* Temporarily disable tests

* Revert webpack change

* Improve Search Header

* fix: fix tests and cleanup code

* reenable tests

* refactor: remove unused zoom change listener from SearchMap component

* fix: Fix BrowseResultsPage

* fix: add some logging

* fix: remove console log

* attempt to fix category switching issue

* Don't reset map init

* fix: remove logging

* Pulling events from Open Data Portal

* fix: add days of week and allow for series of events

* fix: refresh styles

* fix: test

* fix: remove exploration work for eligibility filtering

* fix: Fix some visual inconsistencies and bugs

* rename featued events and shuffle homepage order

* fix: calendar section background color

* Remove commented code

* fix: ensure https protocol

* fix: make it more robust and add security considerations

* fix: split apart the calendar

* Use React-GTM-Module

Add typing for react-gtm-module

fix: temporarily deploy Google Analytics to staging

fix: add temporary logging

fix: remove GA4 logging

* fix: add error boundary and remove GA from development

* fix: Page not found

* fix: Rearrange featured resources and the calendar

* Review

* fix: comment

* Eligibility filtering for senior services

* fix: change language (#355)

* fix: change language

* test: fix test

* fix: limit featured resources to first four

* fix: event details page

* feat: Rework events calendar for agenda view

* fix: correct featured events navigation

* test: fix test

* fix: lint

* code review

* fix: z-index issue

* fix: remove extra exclusion filters

* fix: remove comment
chadbrokaw added a commit that referenced this pull request Oct 23, 2025
)

* map exploration, hide expired events, fix weback

* Temporarily disable tests

* Revert webpack change

* Improve Search Header

* fix: fix tests and cleanup code

* reenable tests

* refactor: remove unused zoom change listener from SearchMap component

* fix: Fix BrowseResultsPage

* fix: add some logging

* fix: remove console log

* attempt to fix category switching issue

* Don't reset map init

* fix: remove logging

* Pulling events from Open Data Portal

* fix: add days of week and allow for series of events

* fix: refresh styles

* fix: test

* fix: remove exploration work for eligibility filtering

* fix: Fix some visual inconsistencies and bugs

* rename featued events and shuffle homepage order

* fix: calendar section background color

* Remove commented code

* fix: ensure https protocol

* fix: make it more robust and add security considerations

* fix: split apart the calendar

* Use React-GTM-Module

Add typing for react-gtm-module

fix: temporarily deploy Google Analytics to staging

fix: add temporary logging

fix: remove GA4 logging

* fix: add error boundary and remove GA from development

* fix: Page not found

* fix: Rearrange featured resources and the calendar

* Review

* fix: comment

* Eligibility filtering for senior services

* fix: change language (#355)

* fix: change language

* test: fix test

* fix: limit featured resources to first four

* fix: event details page

* feat: Rework events calendar for agenda view

* fix: correct featured events navigation

* test: fix test

* fix: lint

* code review

* fix: z-index issue

* fix: remove extra exclusion filters

* fix: remove comment

* fix: repurpose feature flag
chadbrokaw added a commit that referenced this pull request Oct 29, 2025
…roduction branches (#359)

* map exploration, hide expired events, fix weback

* Temporarily disable tests

* Revert webpack change

* Improve Search Header

* fix: fix tests and cleanup code

* reenable tests

* refactor: remove unused zoom change listener from SearchMap component

* fix: Fix BrowseResultsPage

* fix: add some logging

* fix: remove console log

* attempt to fix category switching issue

* Don't reset map init

* fix: remove logging

* Pulling events from Open Data Portal

* fix: add days of week and allow for series of events

* fix: refresh styles

* fix: test

* fix: remove exploration work for eligibility filtering

* fix: Fix some visual inconsistencies and bugs

* rename featued events and shuffle homepage order

* fix: calendar section background color

* Remove commented code

* fix: ensure https protocol

* fix: make it more robust and add security considerations

* fix: split apart the calendar

* Use React-GTM-Module

Add typing for react-gtm-module

fix: temporarily deploy Google Analytics to staging

fix: add temporary logging

fix: remove GA4 logging

* fix: add error boundary and remove GA from development

* fix: Page not found

* fix: Rearrange featured resources and the calendar

* Review

* fix: comment

* Eligibility filtering for senior services

* fix: change language (#355)

* fix: change language

* test: fix test

* fix: limit featured resources to first four

* fix: event details page

* feat: Rework events calendar for agenda view

* fix: correct featured events navigation

* test: fix test

* fix: lint

* code review

* fix: z-index issue

* fix: remove extra exclusion filters

* fix: remove comment

* fix: repurpose feature flag

* fix: change dev workflow so that it deploys on all branches besides main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants