-
Notifications
You must be signed in to change notification settings - Fork 0
fix: change language #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change language #355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request improves the event detail page display by updating language and making registration information conditional. The changes focus on clearer labeling and only showing registration sections when relevant data exists.
- Updated "Event Link" label to "View Details" for better clarity
- Made registration section conditional on the presence of a registration link
- Renamed "Education" category to "Education, After School, & Summer Programs"
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/pages/constants.ts | Updated category name for education services |
| app/pages/EventDetailPage/EventDetailPage.tsx | Improved registration section display logic and labeling |
| app/pages/EventDetailPage/EventDetailPage.test.tsx | Updated test to reflect new "View Details" label |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
* fix: change language * test: fix test
* map exploration, hide expired events, fix weback * Temporarily disable tests * Revert webpack change * Improve Search Header * fix: fix tests and cleanup code * reenable tests * refactor: remove unused zoom change listener from SearchMap component * fix: Fix BrowseResultsPage * fix: add some logging * fix: remove console log * attempt to fix category switching issue * Don't reset map init * fix: remove logging * Pulling events from Open Data Portal * fix: add days of week and allow for series of events * fix: refresh styles * fix: test * fix: remove exploration work for eligibility filtering * fix: Fix some visual inconsistencies and bugs * rename featued events and shuffle homepage order * fix: calendar section background color * Remove commented code * fix: ensure https protocol * fix: make it more robust and add security considerations * fix: split apart the calendar * Use React-GTM-Module Add typing for react-gtm-module fix: temporarily deploy Google Analytics to staging fix: add temporary logging fix: remove GA4 logging * fix: add error boundary and remove GA from development * fix: Page not found * fix: Rearrange featured resources and the calendar * Review * fix: comment * Eligibility filtering for senior services * fix: change language (#355) * fix: change language * test: fix test * fix: limit featured resources to first four * fix: event details page * feat: Rework events calendar for agenda view * fix: correct featured events navigation * test: fix test * fix: lint * code review * fix: z-index issue
* map exploration, hide expired events, fix weback * Temporarily disable tests * Revert webpack change * Improve Search Header * fix: fix tests and cleanup code * reenable tests * refactor: remove unused zoom change listener from SearchMap component * fix: Fix BrowseResultsPage * fix: add some logging * fix: remove console log * attempt to fix category switching issue * Don't reset map init * fix: remove logging * Pulling events from Open Data Portal * fix: add days of week and allow for series of events * fix: refresh styles * fix: test * fix: remove exploration work for eligibility filtering * fix: Fix some visual inconsistencies and bugs * rename featued events and shuffle homepage order * fix: calendar section background color * Remove commented code * fix: ensure https protocol * fix: make it more robust and add security considerations * fix: split apart the calendar * Use React-GTM-Module Add typing for react-gtm-module fix: temporarily deploy Google Analytics to staging fix: add temporary logging fix: remove GA4 logging * fix: add error boundary and remove GA from development * fix: Page not found * fix: Rearrange featured resources and the calendar * Review * fix: comment * Eligibility filtering for senior services * fix: change language (#355) * fix: change language * test: fix test * fix: limit featured resources to first four * fix: event details page * feat: Rework events calendar for agenda view * fix: correct featured events navigation * test: fix test * fix: lint * code review * fix: z-index issue * fix: remove extra exclusion filters * fix: remove comment
) * map exploration, hide expired events, fix weback * Temporarily disable tests * Revert webpack change * Improve Search Header * fix: fix tests and cleanup code * reenable tests * refactor: remove unused zoom change listener from SearchMap component * fix: Fix BrowseResultsPage * fix: add some logging * fix: remove console log * attempt to fix category switching issue * Don't reset map init * fix: remove logging * Pulling events from Open Data Portal * fix: add days of week and allow for series of events * fix: refresh styles * fix: test * fix: remove exploration work for eligibility filtering * fix: Fix some visual inconsistencies and bugs * rename featued events and shuffle homepage order * fix: calendar section background color * Remove commented code * fix: ensure https protocol * fix: make it more robust and add security considerations * fix: split apart the calendar * Use React-GTM-Module Add typing for react-gtm-module fix: temporarily deploy Google Analytics to staging fix: add temporary logging fix: remove GA4 logging * fix: add error boundary and remove GA from development * fix: Page not found * fix: Rearrange featured resources and the calendar * Review * fix: comment * Eligibility filtering for senior services * fix: change language (#355) * fix: change language * test: fix test * fix: limit featured resources to first four * fix: event details page * feat: Rework events calendar for agenda view * fix: correct featured events navigation * test: fix test * fix: lint * code review * fix: z-index issue * fix: remove extra exclusion filters * fix: remove comment * fix: repurpose feature flag
…roduction branches (#359) * map exploration, hide expired events, fix weback * Temporarily disable tests * Revert webpack change * Improve Search Header * fix: fix tests and cleanup code * reenable tests * refactor: remove unused zoom change listener from SearchMap component * fix: Fix BrowseResultsPage * fix: add some logging * fix: remove console log * attempt to fix category switching issue * Don't reset map init * fix: remove logging * Pulling events from Open Data Portal * fix: add days of week and allow for series of events * fix: refresh styles * fix: test * fix: remove exploration work for eligibility filtering * fix: Fix some visual inconsistencies and bugs * rename featued events and shuffle homepage order * fix: calendar section background color * Remove commented code * fix: ensure https protocol * fix: make it more robust and add security considerations * fix: split apart the calendar * Use React-GTM-Module Add typing for react-gtm-module fix: temporarily deploy Google Analytics to staging fix: add temporary logging fix: remove GA4 logging * fix: add error boundary and remove GA from development * fix: Page not found * fix: Rearrange featured resources and the calendar * Review * fix: comment * Eligibility filtering for senior services * fix: change language (#355) * fix: change language * test: fix test * fix: limit featured resources to first four * fix: event details page * feat: Rework events calendar for agenda view * fix: correct featured events navigation * test: fix test * fix: lint * code review * fix: z-index issue * fix: remove extra exclusion filters * fix: remove comment * fix: repurpose feature flag * fix: change dev workflow so that it deploys on all branches besides main
This pull request updates the event detail page to improve how registration information is displayed and clarifies category naming. The most significant changes are the renaming of the "Event Link" to "View Details," conditional rendering of registration details, and an updated category name for clarity.
Event Registration Section Improvements:
Category Naming Clarification: