-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derive initial checkbox state from query string #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is fine, but I feel like if I allow it, I'm just gonna write another PR that does this using Onyx properly. The query params are not ideal because they are not discoverable. The only way people will use them is if they are specifically told and educated about them, and I think that's doing a disservice to the feature.
Also, in order to get a PR merged and deployed, you'll need to follow all the instructions in the readme. There are several version files you need to bump, for example.
Is that NAB?
I personally think that's fine for now. I don't know that anyone but me wants this right now |
OK, if that's what you would like, then sure :) |
Haha yeah, I'd prefer shipping this quickly even if we decide to refactor it later, over having to learn how to re-implement this |
Updated |
I'll leave it to you to deploy this! |
Tested various initial states
And tested toggling the checkboxes