Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move checkbox config to onyx #221

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Move checkbox config to onyx #221

merged 3 commits into from
Jan 2, 2025

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Jan 1, 2025

cc @cead22

This PR refactors #220 to store the information in Onyx so the settings are automatically remembered.

Tests

  1. Go to the K2 dashboard
  2. Check some of the checkbox filters for hiding specific issues
  3. Refresh the page
  4. Verify the same checkbox filters were remembered and applied to the dashboard

@tgolen tgolen requested a review from a team January 1, 2025 18:21
@tgolen tgolen self-assigned this Jan 1, 2025
@melvin-bot melvin-bot bot requested review from grgia and removed request for a team January 1, 2025 18:21
Copy link
Contributor

@grgia grgia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, Is there an issue about the purpose of these two PRs?

@grgia grgia merged commit a78acad into main Jan 2, 2025
4 checks passed
@grgia grgia deleted the tgolen-checkboxes-onyx branch January 2, 2025 10:37
@tgolen
Copy link
Contributor Author

tgolen commented Jan 2, 2025

Nah, there wasn't any GH issue for these. It was just something that Carlos and I were discussing in a DM the other day and we thought it would be a nice addition, yet we had some... different opinions on implementation 😂

@tgolen
Copy link
Contributor Author

tgolen commented Jan 2, 2025

I'll work on deploying this today

@cead22
Copy link
Contributor

cead22 commented Jan 2, 2025

Thanks Tim! I looked at the code to see how you implemented it. Next feature I implement I'll use onyx ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants