Skip to content

Closes #883 #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mansur-codes wants to merge 2 commits into
base: main
Choose a base branch
from
+443 −48
Open

Closes #883 #1288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3afa8d
`feat(tests): add credential/ZK subsystem test coverage (#883)`
mansur-codes Aug 28, 2026
2c356af
Merge branch 'main' into main
mansur-codes Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 101 additions & 4 deletions packages/contracts/contracts/linkora-contracts/src/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,7 @@ fn test_tip_fee_split() {
// Initialize with 2.5% fee (250 bps)
client.initialize(&admin, &treasury, &250);

client.set_profile(&author, &String::from_str(&env, "author"), &Address::generate(&env));
let token = setup_token(&env, &tipper);
client.set_profile(&author, &String::from_str(&env, "author"), &token);
let post_id = client.create_post(&author, &String::from_str(&env, "Fee test post"));
Expand Down Expand Up @@ -535,6 +536,7 @@ fn test_tip_blocked_by_author() {

client.initialize(&admin, &treasury, &250);

client.set_profile(&author, &String::from_str(&env, "author"), &Address::generate(&env));
let token = setup_token(&env, &tipper);
client.set_profile(&author, &String::from_str(&env, "author"), &token);
let post_id = client.create_post(&author, &String::from_str(&env, "Test post"));
Expand All @@ -561,6 +563,7 @@ fn test_tip_after_unblock() {

client.initialize(&admin, &treasury, &250);

client.set_profile(&author, &String::from_str(&env, "author"), &Address::generate(&env));
let token = setup_token(&env, &tipper);
client.set_profile(&author, &String::from_str(&env, "author"), &token);
let post_id = client.create_post(&author, &String::from_str(&env, "Test post"));
Expand Down Expand Up @@ -635,6 +638,7 @@ fn test_tip_block_preserves_no_state_changes_on_panic() {

client.initialize(&admin, &treasury, &250);

client.set_profile(&author, &String::from_str(&env, "author"), &Address::generate(&env));
let token = setup_token(&env, &tipper);
client.set_profile(&author, &String::from_str(&env, "author"), &token);
let post_id = client.create_post(&author, &String::from_str(&env, "block-prevented tip post"));
Expand Down Expand Up @@ -729,6 +733,7 @@ fn test_tip_block_is_unidirectional_blocker_can_still_tip_blocked() {
let token = setup_token(&env, &blocker);
StellarAssetClient::new(&env, &token).mint(&blocked_user, &10_000);

client.set_profile(&blocked_user, &String::from_str(&env, "blocked_user"), &Address::generate(&env));
let post_id = client.create_post(
&blocked_user,
&String::from_str(&env, "blocked_user is the author here"),
Expand Down Expand Up @@ -3096,6 +3101,7 @@ fn test_tip_full_flow_no_fee() {
// Initialize with fee_bps = 0 (no fee)
client.initialize(&admin, &treasury, &0);

client.set_profile(&author, &String::from_str(&env, "author"), &Address::generate(&env));
let token = setup_token(&env, &tipper);
client.set_profile(&author, &String::from_str(&env, "author"), &token);
let post_id = client.create_post(&author, &String::from_str(&env, "No-fee tip test"));
Expand Down Expand Up @@ -3141,6 +3147,7 @@ fn test_tip_full_flow_with_5_percent_fee() {
// Initialize with fee_bps = 500 (5%)
client.initialize(&admin, &treasury, &500);

client.set_profile(&author, &String::from_str(&env, "author"), &Address::generate(&env));
let token = setup_token(&env, &tipper);
client.set_profile(&author, &String::from_str(&env, "author"), &token);
let post_id = client.create_post(&author, &String::from_str(&env, "5% fee tip test"));
Expand Down Expand Up @@ -3228,6 +3235,7 @@ fn test_tip_fee_split_matches_fee_bps_config() {
// Use 250 bps (2.5%)
client.initialize(&admin, &treasury, &250);

client.set_profile(&author, &String::from_str(&env, "author"), &Address::generate(&env));
let token = setup_token(&env, &tipper);
client.set_profile(&author, &String::from_str(&env, "author"), &token);
let post_id = client.create_post(&author, &String::from_str(&env, "Fee split config test"));
Expand Down Expand Up @@ -3750,6 +3758,7 @@ fn test_tip_cooldown_rejects_within_window() {
// Use a short window so both tips happen within it
client.set_tip_cooldown_window(&admin, &10);

client.set_profile(&author, &String::from_str(&env, "author"), &Address::generate(&env));
let token = setup_token(&env, &tipper);
client.set_profile(&author, &String::from_str(&env, "author"), &token);
let post_id = client.create_post(&author, &String::from_str(&env, "cooldown test post"));
Expand All @@ -3775,6 +3784,7 @@ fn test_tip_cooldown_allows_after_window() {
client.initialize(&admin, &treasury, &0);
client.set_tip_cooldown_window(&admin, &10);

client.set_profile(&author, &String::from_str(&env, "author"), &Address::generate(&env));
let token = setup_token(&env, &tipper);
client.set_profile(&author, &String::from_str(&env, "author"), &token);
let post_id = client.create_post(&author, &String::from_str(&env, "cooldown test post"));
Expand Down Expand Up @@ -4087,6 +4097,7 @@ fn test_tip_cooldown_uses_typed_storage_key() {
client.initialize(&admin, &treasury, &0);
client.set_tip_cooldown_window(&admin, &100);

client.set_profile(&author, &String::from_str(&env, "author"), &Address::generate(&env));
let token = setup_token(&env, &tipper);
client.set_profile(&author, &String::from_str(&env, "author"), &token);
let post_id = client.create_post(&author, &String::from_str(&env, "cooldown key test"));
Expand Down Expand Up @@ -5189,6 +5200,7 @@ fn test_tip_cooldown_100_ledgers_immediate_retip_panics() {
client.initialize(&admin, &treasury, &0);
client.set_tip_cooldown_window(&admin, &100);

client.set_profile(&author, &String::from_str(&env, "author"), &Address::generate(&env));
let token = setup_token(&env, &tipper);
client.set_profile(&author, &String::from_str(&env, "author"), &token);
let post_id = client.create_post(&author, &String::from_str(&env, "cooldown 100 post"));
Expand All @@ -5215,6 +5227,7 @@ fn test_tip_cooldown_100_ledgers_allows_after_advance() {
client.initialize(&admin, &treasury, &0);
client.set_tip_cooldown_window(&admin, &100);

client.set_profile(&author, &String::from_str(&env, "author"), &Address::generate(&env));
let token = setup_token(&env, &tipper);
client.set_profile(&author, &String::from_str(&env, "author"), &token);
let post_id = client.create_post(&author, &String::from_str(&env, "cooldown 100 post"));
Expand Down Expand Up @@ -5681,6 +5694,7 @@ fn test_tip_panics_when_tipper_blocked_author() {
let tipper = Address::generate(&env);
let author = Address::generate(&env);

client.set_profile(&author, &String::from_str(&env, "author"), &Address::generate(&env));
let token = setup_token(&env, &tipper);
client.set_profile(&author, &String::from_str(&env, "author"), &token);
let post_id = client.create_post(&author, &String::from_str(&env, "test post"));
Expand Down Expand Up @@ -7859,7 +7873,7 @@ fn test_verify_credential_empty_proof() {

let user = Address::generate(&env);

// For empty proof, root should equal leaf
// For empty proof (depth-0), root should equal leaf
let leaf = BytesN::from_array(&env, &[1u8; 32]);
let root = leaf.clone();
let proof: Vec<BytesN<32>> = vec![&env];
Expand All @@ -7870,10 +7884,15 @@ fn test_verify_credential_empty_proof() {
&sign_credential_root(&env, &signing_key, &root),
);

let nullifier = BytesN::from_array(&env, &[10u8; 32]);
let result = client.verify_credential(&user, &proof, &leaf, &nullifier);
let nullifier1 = BytesN::from_array(&env, &[10u8; 32]);
let result1 = client.verify_credential(&user, &proof, &leaf, &nullifier1);
assert!(result1, "empty proof should work when root equals leaf");

assert!(result, "empty proof should work when root equals leaf");
// Empty proof with wrong leaf (leaf != root) should fail
let wrong_leaf = BytesN::from_array(&env, &[2u8; 32]);
let nullifier2 = BytesN::from_array(&env, &[20u8; 32]);
let result2 = client.verify_credential(&user, &proof, &wrong_leaf, &nullifier2);
assert!(!result2, "empty proof with non-matching leaf should return false");
}

#[test]
Expand Down Expand Up @@ -7908,6 +7927,84 @@ fn test_verify_credential_max_depth_proof() {
assert!(result, "max depth proof should verify correctly");
}

#[test]
fn test_update_credential_root_32_bytes_accepted() {
let env = Env::default();
env.mock_all_auths();
let (client, admin, _) = setup_contract(&env);
let signing_key = credential_authority_signing_key(1);
client.set_credential_authority(&admin, &credential_authority_pubkey(&env, &signing_key));

let user = Address::generate(&env);
let root = BytesN::from_array(&env, &[0xab; 32]);

client.update_credential_root(
&user,
&root,
&sign_credential_root(&env, &signing_key, &root),
);

let retrieved = client.get_credential_root(&user).unwrap();
assert_eq!(retrieved.to_array().len(), 32);
assert_eq!(retrieved, root);
}

#[test]
fn test_get_credential_root_correct_after_update() {
let env = Env::default();
env.mock_all_auths();
let (client, admin, _) = setup_contract(&env);
let signing_key = credential_authority_signing_key(1);
client.set_credential_authority(&admin, &credential_authority_pubkey(&env, &signing_key));

let user = Address::generate(&env);
let root = BytesN::from_array(&env, &[42u8; 32]);

assert!(client.get_credential_root(&user).is_none());

client.update_credential_root(
&user,
&root,
&sign_credential_root(&env, &signing_key, &root),
);

let retrieved = client.get_credential_root(&user);
assert_eq!(retrieved, Some(root));
}

#[test]
fn test_get_credential_root_none_after_cleared() {
// Contract has no explicit clear_root API; root is cleared when user profile is deleted via delete_profile
let env = Env::default();
env.mock_all_auths();
let (client, admin, _) = setup_contract(&env);
let signing_key = credential_authority_signing_key(1);
client.set_credential_authority(&admin, &credential_authority_pubkey(&env, &signing_key));

let user = Address::generate(&env);
client.set_profile(
&user,
&String::from_str(&env, "alice"),
&Address::generate(&env),
);

let root = BytesN::from_array(&env, &[7u8; 32]);
client.update_credential_root(
&user,
&root,
&sign_credential_root(&env, &signing_key, &root),
);
assert_eq!(client.get_credential_root(&user), Some(root));

// Deleting profile removes StorageKey::CredentialRoot(user)
client.delete_profile(&user);
assert_eq!(
client.get_credential_root(&user),
None,
"should return None after credential root storage is cleared on delete_profile"
);
}

// ── Issue #956: governance parameter bounds ──────────────────────────────────

#[test]
Expand Down
Loading
Loading