Closes #883 - #1288
Open
mansur-codes wants to merge 2 commits into
Open
Conversation
|
@mansur-codes Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
|
Resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive unit, invariant, and fuzz test coverage for the credential/ZK subsystem (
update_credential_root,verify_credential,get_credential_root). These three functions had zero tests despite being central to the platform's identity verification system. 322 tests pass, 387 across all integration suites.Type of Change
Testing Done
Added 15 unit tests in
test.rs, 7 invariant tests intests/invariants.rs, and 5 fuzz property tests intests/fuzz_credential.rs. Coverage includes valid/invalid Merkle proofs, nullifier replay prevention, cross-user root isolation, depth-0 empty proof behavior, and nullifier non-consumption on failed verification. Also fixed 16 pre-existing tip tests that were failing due to missingset_profilecalls for author addresses.cargo testpassesChecklist
Related Issue
Closes #883