Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Simplify multihost example, no need for extra script #903

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[docs] Simplify multihost example, no need for extra script #903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions docs/src/tutorials/multihost.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,10 @@ will run on multiple devices across multiple nodes.
#SBATCH --constraint=gpu

export JULIA_DEBUG="Reactant,Reactant_jll"

srun --preserve-env bash ./matmul.sh
```

```bash [matmul.sh]
#!/bin/bash -l

# Important else XLA might hang indefinitely
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason doing this in a single script wasn't unsetting the env vars in the compute nodes

unset no_proxy http_proxy https_proxy NO_PROXY HTTP_PROXY HTTPS_PROXY
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
unset no_proxy http_proxy https_proxy NO_PROXY HTTP_PROXY HTTPS_PROXY

Let's remove this in entirety, and add a tip later on saying if Reactant prints a warning ...., then you should unset those vars like ...


julia --project=. --threads=auto matmul_sharded.jl
srun --preserve-env julia --project=. --threads=auto matmul_sharded.jl
```

```julia [matmul_sharded.jl]
Expand Down