[docs] Simplify multihost example, no need for extra script #903
+1
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
reviewed
Mar 13, 2025
|
|
||
| ```bash [matmul.sh] | ||
| #!/bin/bash -l | ||
|
|
||
| # Important else XLA might hang indefinitely |
There was a problem hiding this comment.
For some reason doing this in a single script wasn't unsetting the env vars in the compute nodes
avik-pal
reviewed
Mar 13, 2025
|
|
||
| ```bash [matmul.sh] | ||
| #!/bin/bash -l | ||
|
|
||
| # Important else XLA might hang indefinitely | ||
| unset no_proxy http_proxy https_proxy NO_PROXY HTTP_PROXY HTTPS_PROXY |
There was a problem hiding this comment.
Suggested change
| unset no_proxy http_proxy https_proxy NO_PROXY HTTP_PROXY HTTPS_PROXY |
Let's remove this in entirety, and add a tip later on saying if Reactant prints a warning ...., then you should unset those vars like ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.