CMDCT-2794 (Pt. I): Setup MCR w/ Zustand for State Management #11518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karla-vm
changed the title
karla-vm
requested review from
BearHanded,
braxex and
cassandradanger
as code owners
gmrabian
previously approved these changes
Nov 14, 2023
3 tasks
gmrabian
previously approved these changes
Nov 16, 2023
britt-mo
previously approved these changes
Nov 16, 2023
BearHanded
reviewed
Nov 16, 2023
|
Code Climate has analyzed commit d57cfbc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 94.7% (90% is the threshold). This pull request will bring the total coverage in the repository to 95.8% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converting the state management of MCR from
Context APItoZustand(following the patterns implemented inMFP).This PR covers the initial setup:
UserProvider+ corresponding testsRelated ticket(s)
CMDCT-2784
How to test
Running this locally, you should be able to log in / log out from MCR as expected.
Optionally: install the Redux Devtools Chrome extension or the Firefox Redux Devtools extension
You should see the
userobject and a few other initial states on the extension ✨Important updates
cd services/ui-src yarn installAuthor checklist
convert to a different template: test → val | val → prod