CMDCT-2794 (Pt. II): Setup MCR w/ Zustand for State Management #11520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karla-vm
requested review from
BearHanded,
braxex and
cassandradanger
as code owners
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit c522b7f and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 77.9% (90% is the threshold). This pull request will bring the total coverage in the repository to 95.7% (-0.2% change). View more on Code Climate. |
gmrabian
reviewed
Nov 15, 2023
This reverts commit ca5d93c.
… field in choicelist (#11514) Co-authored-by: Nicholas Summers <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…"EMFILE - too many open files error" (#11522)
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up PR for Part I.
This is a stacked PR covers the Admin Banner setup and its corresponding tests.
Related ticket(s)
CMDCT-2974
How to test
Sign in as an Admin and make sure you're able to create and delete banners under
My AccountImportant updates
Author checklist
convert to a different template: test → val | val → prod