chore(lint): enable errname

.golangci.yaml

@@ -18,7 +18,6 @@ linters:
     - err113
     - errcheck
     - errchkjson
-    - errname
     - errorlint
     - exhaustive
     - exhaustruct

buildcontext/detectbuildfile.go

@@ -12,13 +12,13 @@ import (
 	"github.com/pkg/errors"
 )
 
-// ErrEarthfileNotExist is the struct indicating that file does not exist.
-type ErrEarthfileNotExist struct {
+// EarthfileNotExistError is the struct indicating that file does not exist.
+type EarthfileNotExistError struct {
 	Target string
 }
 
-// Error is function required by error interface.
-func (err ErrEarthfileNotExist) Error() string {
+// Error implements [error] interface.
+func (err EarthfileNotExistError) Error() string {
 	return "No Earthfile nor build.earth file found for target " + err.Target
 }
 
@@ -36,7 +36,7 @@ func detectBuildFile(ref domain.Reference, localDir string) (string, error) {
 
 		_, err = os.Stat(buildEarthPath)
 		if os.IsNotExist(err) {
-			return "", ErrEarthfileNotExist{Target: ref.String()}
+			return "", EarthfileNotExistError{Target: ref.String()}
 		} else if err != nil {
 			return "", errors.Wrapf(err, "stat file %s", buildEarthPath)
 		}
@@ -78,7 +78,7 @@ func detectBuildFileInRef(
 		return buildEarthPath, nil
 	}
 
-	return "", ErrEarthfileNotExist{Target: earthlyRef.String()}
+	return "", EarthfileNotExistError{Target: earthlyRef.String()}
 }
 
 func fileExists(ctx context.Context, ref gwclient.Reference, fpath string) (bool, error) {

cmd/earthly/subcmd/ls_cmds.go

@@ -90,7 +90,7 @@ func (a *List) action(cliCtx *cli.Context) error {
 
 	// the +base is required to make ParseTarget work; however is ignored by GetTargets
 	target, err := domain.ParseTarget(targetToParse + "+base")
-	if errors.Is(err, buildcontext.ErrEarthfileNotExist{}) {
+	if errors.Is(err, buildcontext.EarthfileNotExistError{}) {
 		return errors.Errorf("unable to locate Earthfile under %s", targetToDisplay)
 	} else if err != nil {
 		return err
@@ -99,7 +99,7 @@ func (a *List) action(cliCtx *cli.Context) error {
 	targets, err := earthfile2llb.GetTargets(cliCtx.Context, resolver, gwClient, target)
 	if err != nil {
 		switch err := errors.Cause(err).(type) {
-		case *buildcontext.ErrEarthfileNotExist:
+		case *buildcontext.EarthfileNotExistError:
 			return errors.Errorf("unable to locate Earthfile under %s", targetToDisplay)
 		default:
 			return err

earthfile2llb/converter.go

@@ -3430,7 +3430,7 @@ func (c *Converter) expandWildcardTargets(ctx context.Context, fullTargetName st
 
 		data, _, _, err := c.ResolveReference(ctx, childTarget)
 		if err != nil {
-			notExist := buildcontext.ErrEarthfileNotExist{}
+			notExist := buildcontext.EarthfileNotExistError{}
 			if errors.As(err, &notExist) {
 				continue
 			}

earthfile2llb/interpretererror.go

@@ -49,6 +49,7 @@ func WrapError(
 	}
 }
 
+// Error implements [error] interface.
 func (ie InterpreterError) Error() string {
 	var err error
 	if ie.cause != nil {

inputgraph/error.go

@@ -16,6 +16,7 @@ type Error struct {
 	msg    string
 }
 
+// Error implements [error] interface.
 func (e *Error) Error() string {
 	parts := []string{}
 	if e.msg != "" {

util/cliutil/earthlydir.go

@@ -18,7 +18,7 @@ var (
 
 var (
 	earthlyDirCreateOnce sync.Once
-	earthlyDirCreateErr  error
+	errEarthlyDirCreate  error
 )
 
 // GetEarthlyDir returns the .earthly dir. (Usually ~/.earthly).
@@ -51,27 +51,27 @@ func GetOrCreateEarthlyDir(installName string) (string, error) {
 	earthlyDirCreateOnce.Do(func() {
 		earthlyDirExists, err := fileutil.DirExists(earthlyDir)
 		if err != nil {
-			earthlyDirCreateErr = errors.Wrapf(err, "unable to create dir %s", earthlyDir)
+			errEarthlyDirCreate = errors.Wrapf(err, "unable to create dir %s", earthlyDir)
 			return
 		}
 
 		if !earthlyDirExists {
 			err := os.MkdirAll(earthlyDir, 0o755) // #nosec G301
 			if err != nil {
-				earthlyDirCreateErr = errors.Wrapf(err, "unable to create dir %s", earthlyDir)
+				errEarthlyDirCreate = errors.Wrapf(err, "unable to create dir %s", earthlyDir)
 				return
 			}
 
 			if earthlyDirSudoUser != nil {
 				err := fileutil.EnsureUserOwned(earthlyDir, earthlyDirSudoUser)
 				if err != nil {
-					earthlyDirCreateErr = errors.Wrapf(err, "failed to ensure %s is owned by %s", earthlyDir, earthlyDirSudoUser)
+					errEarthlyDirCreate = errors.Wrapf(err, "failed to ensure %s is owned by %s", earthlyDir, earthlyDirSudoUser)
 				}
 			}
 		}
 	})
 
-	return earthlyDir, earthlyDirCreateErr
+	return earthlyDir, errEarthlyDirCreate
 }
 
 // IsBootstrapped provides a tentatively correct guess about the state of our bootstrapping.

util/hint/hinterror.go

@@ -18,7 +18,7 @@ type Error struct {
 	hints []string
 }
 
-// Error returns the error string.
+// Error implements [error] interface.
 func (e *Error) Error() string {
 	return fmt.Sprintf(`%v:Hint: %v`, e.err, e.Hint())
 }

util/params/paramerror.go

@@ -24,6 +24,7 @@ func Wrapf(err error, format string, args ...any) error {
 	}
 }
 
+// Error implements [error] interface.
 func (e *Error) Error() string {
 	if e.cause != nil {
 		return fmt.Errorf("%s: %w", e.msg, e.cause).Error()