chore: adjust delete PR workflow name and set required permissions#692
Merged
gwarf merged 2 commits intoEGI-Federation:mainfrom Jan 9, 2025
gwarf:fix_preview_cleaning
Merged
chore: adjust delete PR workflow name and set required permissions#692gwarf merged 2 commits intoEGI-Federation:mainfrom gwarf:fix_preview_cleaning
gwarf merged 2 commits intoEGI-Federation:mainfrom
gwarf:fix_preview_cleaning
Conversation
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. |
enolfc
approved these changes
Jan 9, 2025
Contributor
enolfc
left a comment
There was a problem hiding this comment.
LGTM, but I guess we need to test again by merging
Member
Author
|
@enolfc it seems to have worked at least when removing the label, I've tried removing it on #664:
|
Member
Author
|
Hm, there may still be issues, apparently it worked when adding/removing the label but not when merging the PR:
While the workflow file is apparently the same for both run, the permissions logged in the jobs are different: vs |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


I think the deletion of PR preview never works, let's see if we can get it working.