Skip to content

Give permissions to write#687

Merged
gwarf merged 1 commit intoEGI-Federation:mainfrom
enolfc:preview
Dec 18, 2024
Merged

Give permissions to write#687
gwarf merged 1 commit intoEGI-Federation:mainfrom
enolfc:preview

Conversation

@enolfc
Copy link
Contributor

@enolfc enolfc commented Dec 18, 2024

Summary

Try to make the build preview work again

Related issue : #685

@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ no-files-to-check 1

See ❌ Event descriptions for more information.

@enolfc enolfc added the safe for preview Pull request vetted as safe for preview label Dec 18, 2024
Copy link
Member

@gwarf gwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwarf gwarf merged commit d9539d4 into EGI-Federation:main Dec 18, 2024
@enolfc enolfc deleted the preview branch December 18, 2024 14:58
@enolfc
Copy link
Contributor Author

enolfc commented Dec 18, 2024

still does not build previews :(

@gwarf
Copy link
Member

gwarf commented Jan 9, 2025

Wasn't the issue that it was building, but not deploying? In fact I don't think write is needed for the build workflow.

@enolfc
Copy link
Contributor Author

enolfc commented Jan 9, 2025

should we revert this one then?

@gwarf
Copy link
Member

gwarf commented Jan 9, 2025

Did it via #692.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe for preview Pull request vetted as safe for preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants