Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,22 @@
<Owners>$(Company)</Owners>
<Authors>Dynamo</Authors>
<Product>Dynamo</Product>
<Copyright>Copyright © Autodesk, Inc 2024</Copyright>
<Copyright>Copyright © Autodesk, Inc 2025</Copyright>

<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>

<!-- Using `VersionPrefix` allows specifying a `version-suffix` argument when packing for beta releases. -->
<VersionPrefix>1.4.0</VersionPrefix>
<DynamoPackageVersion>4.0.0-beta2860</DynamoPackageVersion>
<!-- This is the version used for created NuGet packages. Using `VersionPrefix` allows specifying a `version-suffix` argument when packing for beta releases. -->
<MS_PACKAGE_VERSION Condition="'$(MS_PACKAGE_VERSION)' == ''">0.0.0.0</MS_PACKAGE_VERSION>
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default version '0.0.0.0' may cause confusion if the environment variable is not set, potentially leading to invalid package versions being published. Consider using a more explicit default like '0.0.0-dev' or adding validation to fail the build if MS_PACKAGE_VERSION is not provided for release builds.

Suggested change
<MS_PACKAGE_VERSION Condition="'$(MS_PACKAGE_VERSION)' == ''">0.0.0.0</MS_PACKAGE_VERSION>
<MS_PACKAGE_VERSION Condition="'$(MS_PACKAGE_VERSION)' == ''">0.0.0-dev</MS_PACKAGE_VERSION>

Copilot uses AI. Check for mistakes.
<VersionPrefix>$(MS_PACKAGE_VERSION)</VersionPrefix>
<DynamoPackageVersion>4.0.0.3277</DynamoPackageVersion>
<DynamoVersion>4.0</DynamoVersion>

<!--Aids in code analysis.-->
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
<AppendRuntimeIdentifierToOutputPath>false</AppendRuntimeIdentifierToOutputPath>
<BuildOutput>$(SolutionDir)\package_output\DSPythonNet3\</BuildOutput>
</PropertyGroup>
</Project>
</PropertyGroup>
</Project>
20 changes: 20 additions & 0 deletions DynamoVisualProgramming.PythonEngine.PythonNet3.nuspec
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<?xml version="1.0"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
<metadata>
<id>DynamoVisualProgramming.PythonEngine.PythonNet3</id>
<version>$version$</version>
<authors>Autodesk</authors>
<owners>Autodesk</owners>
<license type="expression">Apache-2.0</license>
<projectUrl>https://github.com/DynamoDS/PythonNet3Engine</projectUrl>
<requireLicenseAcceptance>false</requireLicenseAcceptance>
<description>PythonNet3 Engine Nuget, it contains the necessary binaries to load the PythonNet3 engine to Dynamo</description>
<copyright>Copyright Autodesk 2025</copyright>
</metadata>
<files>
<file src="logo.png" target="content\logo\" />
<file src="package_output\DSPythonNet3\pkg.json" target="content\manifest\" />
<file src="package_output\DSPythonNet3\bin\**" target="lib\net10.0\" exclude="**\*.pdb;" />
<file src="package_output\DSPythonNet3\extra\**" target="lib\net10.0\" exclude="**\*.pdb;" />
</files>
</package>
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ Builds are published to [Jenkins](https://master-5.jenkins.autodesk.com/job/Dyna
## Deployment

The repository uses the release branch to deploy to [Dynamo Package Manager](www.dynamopackages.com).
As well as to public Nuget: https://www.nuget.org/packages/DynamoVisualProgramming.PythonEngine.PythonNet3
(Make sure to update the binary version in Directory.build.props before releasing and match it to the version that will be deployed after release)
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parenthetical note is awkwardly phrased and unclear. Consider revising to: 'Note: Update the binary version in Directory.Build.props before each release to match the deployment version.' Also consider moving this to a separate bullet point or callout box for better visibility.

Suggested change
(Make sure to update the binary version in Directory.build.props before releasing and match it to the version that will be deployed after release)
**Note:** Update the binary version in `Directory.Build.props` before each release so that it matches the deployment version.

Copilot uses AI. Check for mistakes.

The package `PythonNet3 Engine` is a dynamo package that is consumed by dynamo users using the Package Manager. The following explains the deployment process to continously push updates to that package.

Expand Down
Binary file added logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions nuget.config
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<configuration>
<packageSources>
<add key="Public Nuget" value="https://api.nuget.org/v3/index.json" />
</packageSources>
</configuration>
16 changes: 15 additions & 1 deletion pipeline.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
version: 1.4.6
pipeline_os: windows
create_pr_release_to_master: true
create_pr_release_to_public_master: true
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field name changed from 'create_pr_release_to_master' to 'create_pr_release_to_public_master'. The addition of 'public_' seems inconsistent with typical naming conventions. Consider verifying this is the correct field name expected by the pipeline configuration, as this appears to be a substantive change rather than a simple rename.

Suggested change
create_pr_release_to_public_master: true
create_pr_release_to_master: true

Copilot uses AI. Check for mistakes.

env:
- GITHUB_ACCESS_TOKEN_ID: github_access_token_acsbuildguy
- SLACK_QUANTUM_BUILD_CHANNEL : "#dynamo-jenkinsbuild"
- JENKINS_NODE_WIN: CDA-VS22-DT

jenkins_creds:
-
type: secretText
credentialsId: dynamovisualprogramming_nuget_api_key
secretText: API_KEY

code_analysis:
sonarqube:
source_encoding: UTF-8
Expand Down Expand Up @@ -44,3 +50,11 @@ deployment:
use_dev_pm: false
outputs:
- DSPythonNet3.zip
-
type: nuget
custom_api_key: ${API_KEY}
nuget_config_file: nuget.config
nuspec_files:
- DynamoVisualProgramming.PythonEngine.PythonNet3.nuspec
package_version_cmd: echo %_PACKAGE_VERSION%
destination_source_name: Public Nuget
Loading