-
Notifications
You must be signed in to change notification settings - Fork 4
Set up Nuget deploy pipeline #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Introduced a nuspec file and nuget.config for packaging DynamoVisualProgramming.PythonEngine.PythonNet3. Updated pipeline.yml to support NuGet deployment using a secret API key and new configuration files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR establishes a NuGet deployment pipeline for DynamoVisualProgramming.PythonEngine.PythonNet3 alongside the existing Dynamo Package Manager deployment. The changes introduce NuGet packaging configuration files and update the CI/CD pipeline to support automated NuGet publishing.
Key changes:
- Added NuGet package specification and configuration files
- Updated CI/CD pipeline to include NuGet deployment with API key credential handling
- Bumped version numbers across pipeline and build configuration files
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pipeline.yml | Added NuGet deployment configuration with credentials and package settings |
| nuget.config | Defined NuGet package source pointing to the public NuGet repository |
| DynamoVisualProgramming.PythonEngine.PythonNet3.nuspec | Specified NuGet package metadata and file inclusions for the PythonNet3 engine |
| README.md | Documented the new NuGet deployment process and version management requirement |
| Directory.Build.props | Updated copyright year and version prefix to align with new release |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
I think you should be able to follow the pattern used by Player: |
Refactored versioning in Directory.Build.props to use MS_PACKAGE_VERSION and updated DynamoPackageVersion. Modified nuspec to use a variable for version and include logo.png in the package. Added logo.png to the repository.
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| version: 1.4.6 | ||
| pipeline_os: windows | ||
| create_pr_release_to_master: true | ||
| create_pr_release_to_public_master: true |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field name changed from 'create_pr_release_to_master' to 'create_pr_release_to_public_master'. The addition of 'public_' seems inconsistent with typical naming conventions. Consider verifying this is the correct field name expected by the pipeline configuration, as this appears to be a substantive change rather than a simple rename.
| create_pr_release_to_public_master: true | |
| create_pr_release_to_master: true |
|
|
||
| The repository uses the release branch to deploy to [Dynamo Package Manager](www.dynamopackages.com). | ||
| As well as to public Nuget: https://www.nuget.org/packages/DynamoVisualProgramming.PythonEngine.PythonNet3 | ||
| (Make sure to update the binary version in Directory.build.props before releasing and match it to the version that will be deployed after release) |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This parenthetical note is awkwardly phrased and unclear. Consider revising to: 'Note: Update the binary version in Directory.Build.props before each release to match the deployment version.' Also consider moving this to a separate bullet point or callout box for better visibility.
| (Make sure to update the binary version in Directory.build.props before releasing and match it to the version that will be deployed after release) | |
| **Note:** Update the binary version in `Directory.Build.props` before each release so that it matches the deployment version. |
| <VersionPrefix>1.4.0</VersionPrefix> | ||
| <DynamoPackageVersion>4.0.0-beta2860</DynamoPackageVersion> | ||
| <!-- This is the version used for created NuGet packages. Using `VersionPrefix` allows specifying a `version-suffix` argument when packing for beta releases. --> | ||
| <MS_PACKAGE_VERSION Condition="'$(MS_PACKAGE_VERSION)' == ''">0.0.0.0</MS_PACKAGE_VERSION> |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default version '0.0.0.0' may cause confusion if the environment variable is not set, potentially leading to invalid package versions being published. Consider using a more explicit default like '0.0.0-dev' or adding validation to fail the build if MS_PACKAGE_VERSION is not provided for release builds.
| <MS_PACKAGE_VERSION Condition="'$(MS_PACKAGE_VERSION)' == ''">0.0.0.0</MS_PACKAGE_VERSION> | |
| <MS_PACKAGE_VERSION Condition="'$(MS_PACKAGE_VERSION)' == ''">0.0.0-dev</MS_PACKAGE_VERSION> |
Introduced a nuspec file and nuget.config for packaging DynamoVisualProgramming.PythonEngine.PythonNet3.
Updated pipeline.yml to support NuGet deployment.
I don't see a better way of doing it with CI, so that the Nuget and Dynamo package version match the binary version, but we will have to update
Directory.build.propsfile each time before deploying a new version. Hopefully we won't have to do it often.