-
Notifications
You must be signed in to change notification settings - Fork 0
Prequal 2025 #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Prequal 2025 #107
Changes from 9 commits
04eab16
b1d671b
ce8872c
6584300
307944f
f92c9a4
d9e9701
7b9b31a
3b54083
010921e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,8 +3,9 @@ | |
|
|
||
| from ament_index_python.packages import get_package_share_directory | ||
| from launch import LaunchDescription | ||
| from launch.actions import IncludeLaunchDescription | ||
| from launch.actions import DeclareLaunchArgument, IncludeLaunchDescription | ||
| from launch.launch_description_sources import PythonLaunchDescriptionSource | ||
| from launch.substitutions import LaunchConfiguration | ||
| from launch_xml.launch_description_sources import XMLLaunchDescriptionSource | ||
|
|
||
|
|
||
|
|
@@ -21,6 +22,12 @@ def generate_launch_description() -> LaunchDescription: | |
|
|
||
| ld = LaunchDescription() | ||
|
|
||
| ld.add_action(DeclareLaunchArgument( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @viethungle-vt1401 I think instead of having "prequal=Boolean", we could consider having "typeOfRun=string", and do "typeOfRun=prequal" etc., I think this might be a bit cleaner if we want to continue to use this schema for, e.g., comp run or something of the sort.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @viethungle-vt1401 whaddya think |
||
| 'prequal', | ||
| default_value='false', | ||
| description='Whether this is being launched for a prequal run', | ||
| )) | ||
|
|
||
| if robot_name in ['oogway', 'oogway_shell']: | ||
| ld.add_action(IncludeLaunchDescription( | ||
| XMLLaunchDescriptionSource(str(pkg_cv / 'launch' / 'depthai_spatial_detection.xml')), | ||
|
|
@@ -29,6 +36,9 @@ def generate_launch_description() -> LaunchDescription: | |
|
|
||
| ld.add_action(IncludeLaunchDescription( | ||
| PythonLaunchDescriptionSource(str(pkg_cv / 'launch' / 'usb_camera_detectors.launch.py')), | ||
| launch_arguments=[ | ||
| ('enable_lane_marker', LaunchConfiguration('prequal')), | ||
| ], | ||
| )) | ||
|
|
||
| return ld | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,9 @@ | |
|
|
||
| from ament_index_python.packages import get_package_share_directory | ||
| from launch import LaunchDescription | ||
| from launch.actions import IncludeLaunchDescription | ||
| from launch.actions import DeclareLaunchArgument, IncludeLaunchDescription | ||
| from launch.conditions import IfCondition | ||
| from launch.substitutions import LaunchConfiguration | ||
| from launch_xml.launch_description_sources import XMLLaunchDescriptionSource | ||
|
|
||
|
|
||
|
|
@@ -20,6 +22,12 @@ def generate_launch_description() -> LaunchDescription: | |
|
|
||
| ld = LaunchDescription() | ||
|
|
||
| ld.add_action(DeclareLaunchArgument( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See comment on |
||
| 'enable_lane_marker', | ||
| default_value='false', | ||
| description='Whether to launch the lane marker detector node', | ||
| )) | ||
|
|
||
| ld.add_action(IncludeLaunchDescription( | ||
| XMLLaunchDescriptionSource(str(pkg_cv / 'launch' / 'usb_camera.xml')), | ||
| launch_arguments={'camera': 'front'}.items(), | ||
|
|
@@ -42,4 +50,9 @@ def generate_launch_description() -> LaunchDescription: | |
| XMLLaunchDescriptionSource(str(pkg_cv / 'launch' / 'hsv_pink_bin_bottom.xml')), | ||
| )) | ||
|
|
||
| ld.add_action(IncludeLaunchDescription( | ||
| XMLLaunchDescriptionSource(str(pkg_cv / 'launch' / 'lane_marker_detector.xml')), | ||
| condition=IfCondition(LaunchConfiguration('enable_lane_marker')), | ||
| )) | ||
|
|
||
| return ld | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,6 @@ def generate_launch_description() -> LaunchDescription: | |
| """ | ||
| pkg_controls = Path(get_package_share_directory('controls')) | ||
| pkg_cv = Path(get_package_share_directory('cv')) | ||
| pkg_dvl_pathfinder = Path(get_package_share_directory('dvl_pathfinder')) # noqa: F841 TODO tf lol | ||
| pkg_dvl_wayfinder = Path(get_package_share_directory('dvl_wayfinder')) | ||
| pkg_offboard_comms = Path(get_package_share_directory('offboard_comms')) | ||
| pkg_sensor_fusion = Path(get_package_share_directory('sensor_fusion')) | ||
|
|
@@ -37,12 +36,21 @@ def generate_launch_description() -> LaunchDescription: | |
| description='Enable or disable recording functionality', | ||
| )) | ||
|
|
||
| ld.add_action(DeclareLaunchArgument( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See comment on |
||
| 'prequal', | ||
| default_value='false', | ||
| description='Whether this is being launched for a prequal run', | ||
| )) | ||
|
|
||
| ld.add_action(IncludeLaunchDescription( | ||
| XMLLaunchDescriptionSource(str(pkg_controls / 'launch' / 'controls.xml')), | ||
| )) | ||
|
|
||
| ld.add_action(IncludeLaunchDescription( | ||
| PythonLaunchDescriptionSource(str(pkg_cv / 'launch' / 'cv.launch.py')), | ||
| launch_arguments=[ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We would need to do |
||
| ('prequal', LaunchConfiguration('prequal')), | ||
| ], | ||
| )) | ||
|
|
||
| if robot_name == 'crush': | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, I think it would be good to have this file re-written using the new HSV filter template to standardize all of our HSV filtering this year. Especially if we can have somebody who doesn't currently understand the CV pipeline help write this. @viethungle-vt1401 do you think this is reasonable? Or do you prefer to just prequal with this code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good idea, though revamping prequal code is not the highest priority so I'm fine either way. I can rope someone to work on it while we are testing other stuff and/or before Crush prequal.