feat: MMD-720 Supernode as proxy for reward requests on behalf of their miners

CONTRIBUTING.md

@@ -272,6 +272,10 @@ substrate-module-new <module-name> <author>
 	* Answer:
 		* Try using a different web browser. Brave may not work, however Chrome might. Try running Polkadot.js app locally instead. See https://stackoverflow.com/questions/45572440/how-to-access-an-insecure-websocket-from-a-secure-website
 
+* Question: Why is loose coupling important?
+    * Answer: Because sometimes things just won't work [see example here](https://matrix.to/#/!HzySYSaIhtyWrwiwEV:matrix.org/$161531016088601OZAjp:matrix.parity.io?via=matrix.parity.io&via=matrix.org&via=corepaper.org)
+        * Substrate Seminar example https://youtu.be/VVU3Io2dACY?t=4425
+
 ## Technical Support <a id="chapter-c00ab7"></a>
 
 * [Discord Chat](https://discord.gg/UuZN2tE)

Cargo.toml

@@ -19,6 +19,7 @@ members = [
     'pallets/roaming/roaming-billing-policies',
     'pallets/roaming/roaming-charging-policies',
     'pallets/roaming/roaming-packet-bundles',
+    'pallets/membership/supernodes',
     'pallets/mining/config/token',
     'pallets/mining/config/hardware',
     'pallets/mining/rates/token',
@@ -29,5 +30,6 @@ members = [
     'pallets/mining/eligibility/hardware',
     'pallets/mining/claims/token',
     'pallets/mining/claims/hardware',
+    'pallets/treasury/dao',
     'runtime',
 ]

custom_types.json

@@ -182,6 +182,20 @@
     "hardware_block_audited": "Moment",
     "hardware_auditor_account_id": "u64"
   },
+  "MiningEligibilityProxy": "[u8; 16]",
+  "MiningEligibilityProxyIndex": "u64",
+  "MiningEligibilityProxyResult": {
+    "proxy_claim_requestor_account_id": "u64",
+    "proxy_claim_total_reward_amount": "u32",
+    "proxy_claim_rewardees_data": "Vec<RewardeeData>",
+    "proxy_claim_block_redeemed": "u64"
+  },
+  "RewardeeData": {
+    "proxy_claim_rewardee_account_id": "u64",
+    "proxy_claim_reward_amount": "u32",
+    "proxy_claim_start_block": "u64",
+    "proxy_claim_interval_blocks": "u64"
+  },
   "MiningClaimsToken": "[u8; 16]",
   "MiningClaimsTokenIndex": "u64",
   "MiningClaimsTokenClaimAmount": "u64",

node/src/chain_spec.rs

@@ -125,10 +125,31 @@ impl Alternative {
                             vec![get_authority_keys_from_seed("Alice")],
                             get_account_id_from_seed::<sr25519::Public>("Alice"),
                             vec![
+                                // DHX DAO Unlocked Reserves Balance
+                                // Given a Treasury ModuleId in runtime parameter_types of
+                                // `py/trsry`, we convert that to its associated address
+                                // using Module ID" to Address" at https://www.shawntabrizi.com/substrate-js-utilities/,
+                                // which generates 5EYCAe5ijiYfyeZ2JJCGq56LmPyNRAKzpG4QkoQkkQNB5e6Z,
+                                // and find its corresponding hex value by pasting the address into
+                                // "AccountId to Hex" at that same link to return
+                                // 6d6f646c70792f74727372790000000000000000000000000000000000000000.
+                                // This is pallet_treasury's account_id.
+                                //
+                                // FIXME - unfortunately we can't get this to work without updating to
+                                // Substrate 3 since earlier versions didn't allow instantiable
+                                // support for treasury module
+                                // https://github.com/paritytech/substrate/pull/7058/files
+                                hex!["6d6f646c70792f74727372790000000000000000000000000000000000000000"].into(),
                                 get_account_id_from_seed::<sr25519::Public>("Alice"),
                                 get_account_id_from_seed::<sr25519::Public>("Bob"),
+                                get_account_id_from_seed::<sr25519::Public>("Charlie"),
+                                get_account_id_from_seed::<sr25519::Public>("Dave"),
+                                // Required otherwise get error when compiling
+                                // `Stash does not have enough balance to bond`
                                 get_account_id_from_seed::<sr25519::Public>("Alice//stash"),
                                 get_account_id_from_seed::<sr25519::Public>("Bob//stash"),
+                                get_account_id_from_seed::<sr25519::Public>("Charlie//stash"),
+                                get_account_id_from_seed::<sr25519::Public>("Dave//stash"),
                             ],
                             true,
                         )
@@ -156,8 +177,8 @@ impl Alternative {
                             get_account_id_from_seed::<sr25519::Public>("Alice"),
                             vec![
                                 // DHX DAO Unlocked Reserves Balance
-                                // 5FmxcuFwGK7kPmQCB3zhk3HtxxJUyb3WjxosF8jvnkrVRLUG
-                                hex!["a42b7518d62a942344fec55d414f1654bf3fd325dbfa32a3c30534d5976acb21"].into(),
+                                // 5EYCAe5ijiYfyeZ2JJCGq56LmPyNRAKzpG4QkoQkkQNB5e6Z
+                                hex!["6d6f646c70792f74727372790000000000000000000000000000000000000000"].into(),
                                 get_account_id_from_seed::<sr25519::Public>("Alice"),
                                 get_account_id_from_seed::<sr25519::Public>("Bob"),
                                 get_account_id_from_seed::<sr25519::Public>("Charlie"),
@@ -211,8 +232,8 @@ impl Alternative {
                             get_account_id_from_seed::<sr25519::Public>("Alice"),
                             vec![
                                 // Endow this account with the DHX DAO Unlocked Reserves Balance
-                                // 5FmxcuFwGK7kPmQCB3zhk3HtxxJUyb3WjxosF8jvnkrVRLUG
-                                hex!["a42b7518d62a942344fec55d414f1654bf3fd325dbfa32a3c30534d5976acb21"].into(),
+                                // 5EYCAe5ijiYfyeZ2JJCGq56LmPyNRAKzpG4QkoQkkQNB5e6Z
+                                hex!["6d6f646c70792f74727372790000000000000000000000000000000000000000"].into(),
                                 // Endow these accounts with a balance so they may bond as authorities
                                 get_account_id_from_seed::<sr25519::Public>("Alice"),
                                 get_account_id_from_seed::<sr25519::Public>("Bob"),
@@ -360,15 +381,22 @@ fn dev_genesis(
             indices: endowed_accounts.iter().enumerate().map(|(index, x)| (index as u32, (*x).clone())).collect(),
         }),
         pallet_balances: Some(BalancesConfig {
-            balances: endowed_accounts.iter().cloned().map(|x|
-                // Insert Public key (hex) of the account without the 0x prefix below
-                if x == UncheckedFrom::unchecked_from(hex!("a42b7518d62a942344fec55d414f1654bf3fd325dbfa32a3c30534d5976acb21").into()) {
-                    (x, INITIAL_DHX_DAO_TREASURY_UNLOCKED_RESERVES_BALANCE)
-                } else {
-                    (x, INITIAL_BALANCE)
-                }
-            )
-            .collect(),
+            balances: endowed_accounts
+                .iter()
+                .cloned()
+                .map(|x| {
+                    // Insert Public key (hex) of the account without the 0x prefix below
+                    if x == UncheckedFrom::unchecked_from(
+                        hex!("6d6f646c70792f74727372790000000000000000000000000000000000000000").into(),
+                    ) {
+                        println!("endowed_account treasury {:?}", x.clone());
+                        return (x, INITIAL_DHX_DAO_TREASURY_UNLOCKED_RESERVES_BALANCE);
+                    } else {
+                        println!("endowed_account {:?}", x.clone());
+                        return (x, INITIAL_BALANCE);
+                    }
+                })
+                .collect(),
         }),
         pallet_session: Some(SessionConfig {
             keys: initial_authorities

pallets/exchange-rate/Cargo.toml

@@ -23,7 +23,7 @@ std = [
 ]
 
 [dependencies]
-codec = { version = '1.2.0', package = 'parity-scale-codec', default-features = false, features = ['derive'] }
+codec = { version = '1.3.0', package = 'parity-scale-codec', default-features = false, features = ['derive'] }
 safe-mix = { version = '1.0.0', default-features = false }
 frame-support = { version = '2.0.0', default_features = false }
 frame-system = { version = '2.0.0', default_features = false }

pallets/lockdrop/rpc/Cargo.toml

@@ -6,7 +6,7 @@ edition = "2018"
 
 [dependencies]
 web3 = "0.13.0"
-codec = { version = '1.2.0', package = 'parity-scale-codec', default-features = false, features = ['derive'] }
+codec = { version = '1.3.0', package = 'parity-scale-codec', default-features = false, features = ['derive'] }
 safe-mix = { version = '1.0.0', default-features = false }
 frame-support = { version = '2.0.0', default_features = false }
 frame-system = { version = '2.0.0', default_features = false }

pallets/membership/supernodes/Cargo.toml

@@ -0,0 +1,42 @@
+[package]
+name = "membership-supernodes"
+version = "2.0.0"
+edition = "2018"
+repository = 'https://github.com/substrate-developer-hub/recipes'
+authors = ['Substrate DevHub <https://github.com/substrate-developer-hub>']
+description = "Fork of Substrate Recipe pallet vec-set. A pallet that implements a storage Set on top of a Vec"
+license = "GPL-3.0-or-later"
+
+[package.metadata.substrate]
+categories = [
+	"pallet",
+	"tutorial",
+	"recipe",
+]
+compatibility_version = "2.0.0"
+
+[dependencies]
+codec = { version = '1.3.0', package = 'parity-scale-codec', default-features = false, features = ['derive'] }
+
+# Substrate packages
+frame-support = { version = '2.0.0', default-features = false }
+frame-system = { version = '2.0.0', default-features = false }
+sp-runtime = { version = '2.0.0', default-features = false }
+sp-std = { version = '2.0.0', default-features = false }
+
+# local packages
+account-set = { path = '../../../traits/account-set', default-features = false }
+
+[dev-dependencies]
+sp-core = { version = '2.0.0', default-features = false }
+sp-io = { version = '2.0.0', default-features = false }
+
+[features]
+default = ['std']
+std = [
+    'account-set/std',
+    'codec/std',
+    'frame-support/std',
+    'frame-system/std',
+    'sp-runtime/std',
+]