feat: MMD-720 Supernode as proxy for reward requests on behalf of their miners #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltfschoen
changed the title
ltfschoen
force-pushed
the
luke/proxy_rewards_supernode
branch
from
d83d425 to
8eb3efc
Compare
ltfschoen
commented
Mar 17, 2021
|
|
||
| // The implementation uses ensure_root, so only the root origin may add and remove members (not account 1) | ||
| assert_ok!(MembershipSupernodesTestModule::add_member(Origin::root(), 0)); | ||
| assert_err!(MembershipSupernodesTestModule::add_member(Origin::root(), 0), DispatchError::BadOrigin); |
There was a problem hiding this comment.
Suggested change
| assert_err!(MembershipSupernodesTestModule::add_member(Origin::root(), 0), DispatchError::BadOrigin); | |
| assert_err!(MembershipSupernodesTestModule::add_member(Origin::signed(0), 0), DispatchError::BadOrigin); |
ltfschoen
commented
Mar 17, 2021
| assert_eq!(Balances::reserved_balance(0), 0); | ||
|
|
||
| assert_ok!(MembershipSupernodesTestModule::remove_member(Origin::root(), 0)); | ||
| assert_err!(MembershipSupernodesTestModule::add_member(Origin::root(), 0), DispatchError::BadOrigin); |
There was a problem hiding this comment.
Suggested change
| assert_err!(MembershipSupernodesTestModule::add_member(Origin::root(), 0), DispatchError::BadOrigin); | |
| assert_err!(MembershipSupernodesTestModule::remove_member(Origin::signed(0), 0), DispatchError::BadOrigin); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Unable to add integration tests for the eligibility proxy pallet because we need pallet-treasury dependencies in the tests and can't get them to work due to
Tipper, so will update to Substrate 3 first