Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust splunk_hec to distinguish decoded and raw bytes received #1167

Merged

Conversation

blt
Copy link
Collaborator

@blt blt commented Dec 17, 2024

What does this PR do?

Similar to #1166 this commit adds a decoded_bytes_received so that the telemetry
from this blackhole matches the others in the project, measuring the raw/wire bytes
in bytes_received.

@blt blt marked this pull request as ready for review December 17, 2024 20:37
@blt blt requested a review from a team as a code owner December 17, 2024 20:37
@blt blt force-pushed the blt/adjust_splunk_hec_to_distinguish_decoded_and_raw_bytes_received branch from 4a8fdab to f46db82 Compare December 17, 2024 20:53
@blt blt changed the base branch from main to blt/update_lading_container_base_image December 17, 2024 20:53
CHANGELOG.md Outdated
## Changed
- The `bytes_received` metric in the HTTP blackhole now tracks wire bytes, the
former metric is preserved with `decoded_bytes_received`.
- The `bytes_received` metric in the HTTP and splunk_heck blackholes now tracks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

splunk_heck -> splunk_hec

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha I always do that.

@blt blt changed the base branch from blt/update_lading_container_base_image to graphite-base/1167 December 17, 2024 22:15
@blt blt force-pushed the blt/adjust_splunk_hec_to_distinguish_decoded_and_raw_bytes_received branch from 326eafa to a16a9dc Compare December 17, 2024 22:15
@blt blt force-pushed the graphite-base/1167 branch from 7565763 to 14c4c66 Compare December 17, 2024 22:15
@blt blt changed the base branch from graphite-base/1167 to main December 17, 2024 22:16
@blt blt force-pushed the blt/adjust_splunk_hec_to_distinguish_decoded_and_raw_bytes_received branch from a16a9dc to 2595746 Compare December 17, 2024 22:16
blt added 4 commits December 17, 2024 14:22
Similar to #1166 this commit adds a `decoded_bytes_received` so that the telemetry
from this blackhole matches the others in the project, measuring the raw/wire bytes
in `bytes_received`.

Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
@blt blt force-pushed the blt/adjust_splunk_hec_to_distinguish_decoded_and_raw_bytes_received branch from 2595746 to b88b136 Compare December 17, 2024 22:22
@blt blt merged commit fdcd881 into main Dec 17, 2024
19 checks passed
Copy link
Collaborator Author

blt commented Dec 17, 2024

Merge activity

  • Dec 17, 5:59 PM EST: A user merged this pull request with Graphite.

@blt blt deleted the blt/adjust_splunk_hec_to_distinguish_decoded_and_raw_bytes_received branch December 17, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants