-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust splunk_hec to distinguish decoded and raw bytes received #1167
Merged
blt
merged 4 commits into
main
from
blt/adjust_splunk_hec_to_distinguish_decoded_and_raw_bytes_received
Dec 17, 2024
Merged
Adjust splunk_hec to distinguish decoded and raw bytes received #1167
blt
merged 4 commits into
main
from
blt/adjust_splunk_hec_to_distinguish_decoded_and_raw_bytes_received
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
blt
force-pushed
the
blt/adjust_splunk_hec_to_distinguish_decoded_and_raw_bytes_received
branch
from
December 17, 2024 20:53
4a8fdab
to
f46db82
Compare
blt
changed the base branch from
main
to
blt/update_lading_container_base_image
December 17, 2024 20:53
This was referenced Dec 17, 2024
Merged
Merged
Merged
goxberry
approved these changes
Dec 17, 2024
CHANGELOG.md
Outdated
## Changed | ||
- The `bytes_received` metric in the HTTP blackhole now tracks wire bytes, the | ||
former metric is preserved with `decoded_bytes_received`. | ||
- The `bytes_received` metric in the HTTP and splunk_heck blackholes now tracks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
splunk_heck -> splunk_hec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha I always do that.
blt
changed the base branch from
blt/update_lading_container_base_image
to
graphite-base/1167
December 17, 2024 22:15
blt
force-pushed
the
blt/adjust_splunk_hec_to_distinguish_decoded_and_raw_bytes_received
branch
from
December 17, 2024 22:15
326eafa
to
a16a9dc
Compare
blt
force-pushed
the
graphite-base/1167
branch
from
December 17, 2024 22:15
7565763
to
14c4c66
Compare
blt
force-pushed
the
blt/adjust_splunk_hec_to_distinguish_decoded_and_raw_bytes_received
branch
from
December 17, 2024 22:16
a16a9dc
to
2595746
Compare
Similar to #1166 this commit adds a `decoded_bytes_received` so that the telemetry from this blackhole matches the others in the project, measuring the raw/wire bytes in `bytes_received`. Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
blt/adjust_splunk_hec_to_distinguish_decoded_and_raw_bytes_received
branch
from
December 17, 2024 22:22
2595746
to
b88b136
Compare
Merge activity
|
blt
deleted the
blt/adjust_splunk_hec_to_distinguish_decoded_and_raw_bytes_received
branch
December 17, 2024 22:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Similar to #1166 this commit adds a
decoded_bytes_received
so that the telemetryfrom this blackhole matches the others in the project, measuring the raw/wire bytes
in
bytes_received
.