Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tonic to workspace #1161

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Migrate tonic to workspace #1161

merged 1 commit into from
Dec 18, 2024

Conversation

blt
Copy link
Collaborator

@blt blt commented Dec 17, 2024

What does this PR do?

This commit migrates the tonic dependency to the workspace. Unfortunately
this leaves tonic-build still in shared/Cargo.toml but it's a start. Goal
here is to make upgrading tonic more achievable.

@blt blt force-pushed the blt/update_lading_container_base_image branch from 95b3633 to c448a45 Compare December 17, 2024 02:48
@blt blt force-pushed the blt/migrate_tonic_to_workspace branch from a084557 to 0939e86 Compare December 17, 2024 02:48
@blt blt force-pushed the blt/update_lading_container_base_image branch from c448a45 to 91b6dc1 Compare December 17, 2024 03:54
@blt blt force-pushed the blt/migrate_tonic_to_workspace branch 2 times, most recently from 3c2b6e5 to 4538629 Compare December 17, 2024 03:58
@blt blt force-pushed the blt/update_lading_container_base_image branch from 56435d6 to 4794989 Compare December 17, 2024 04:00
@blt blt force-pushed the blt/migrate_tonic_to_workspace branch from 4538629 to fe75e46 Compare December 17, 2024 04:00
@blt blt force-pushed the blt/update_lading_container_base_image branch from 4794989 to 573337c Compare December 17, 2024 04:38
@blt blt force-pushed the blt/migrate_tonic_to_workspace branch from fe75e46 to 2255402 Compare December 17, 2024 04:39
@blt blt force-pushed the blt/update_lading_container_base_image branch from 573337c to 6ff2667 Compare December 17, 2024 18:56
@blt blt force-pushed the blt/migrate_tonic_to_workspace branch from 2255402 to 20f8e93 Compare December 17, 2024 18:56
@blt blt force-pushed the blt/update_lading_container_base_image branch 2 times, most recently from be83173 to a2203a5 Compare December 17, 2024 19:30
@blt blt force-pushed the blt/migrate_tonic_to_workspace branch from 20f8e93 to 68160f4 Compare December 17, 2024 19:30
@blt blt force-pushed the blt/update_lading_container_base_image branch from a2203a5 to 7565763 Compare December 17, 2024 20:09
@blt blt force-pushed the blt/migrate_tonic_to_workspace branch 2 times, most recently from d06b6f1 to 481ec34 Compare December 17, 2024 20:50
@blt blt changed the base branch from blt/update_lading_container_base_image to blt/release_0.25.2-rc0 December 17, 2024 20:50
@blt blt mentioned this pull request Dec 17, 2024
@blt blt added the no-changelog label Dec 17, 2024 — with Graphite App
@blt blt marked this pull request as ready for review December 17, 2024 20:51
@blt blt requested a review from a team as a code owner December 17, 2024 20:51
@blt blt force-pushed the blt/release_0.25.2-rc0 branch from 1c3c1d6 to 0ea4307 Compare December 17, 2024 20:53
@blt blt force-pushed the blt/migrate_tonic_to_workspace branch from 481ec34 to fd4539a Compare December 17, 2024 20:53
@blt blt force-pushed the blt/release_0.25.2-rc0 branch 2 times, most recently from f0dbcaa to 24602d8 Compare December 17, 2024 23:00
@blt blt force-pushed the blt/migrate_tonic_to_workspace branch from 0861e41 to 2160811 Compare December 17, 2024 23:00
@blt blt force-pushed the blt/release_0.25.2-rc0 branch from 24602d8 to 139cbef Compare December 17, 2024 23:00
@blt blt force-pushed the blt/migrate_tonic_to_workspace branch 13 times, most recently from 32de0a9 to 463d907 Compare December 18, 2024 15:43
@blt blt force-pushed the blt/release_0.25.2-rc0 branch from 505e6ae to 42cb17f Compare December 18, 2024 15:45
@blt blt force-pushed the blt/migrate_tonic_to_workspace branch 2 times, most recently from 825d439 to 1b988cb Compare December 18, 2024 15:47
@blt blt changed the base branch from blt/release_0.25.2-rc0 to graphite-base/1161 December 18, 2024 17:25
@blt blt force-pushed the graphite-base/1161 branch from 5efa22d to e5bc6c8 Compare December 18, 2024 17:25
@blt blt force-pushed the blt/migrate_tonic_to_workspace branch from 1b988cb to 2a9653a Compare December 18, 2024 17:25
@blt blt changed the base branch from graphite-base/1161 to main December 18, 2024 17:26
This commit migrates the `tonic` dependency to the workspace. Unfortunately
this leaves tonic-build still in shared/Cargo.toml but it's a start. Goal
here is to make upgrading tonic more achievable.

Signed-off-by: Brian L. Troutwine <[email protected]>
@blt blt force-pushed the blt/migrate_tonic_to_workspace branch from 2a9653a to 6bc3be5 Compare December 18, 2024 17:26
@blt blt merged commit 0148bf5 into main Dec 18, 2024
18 checks passed
Copy link
Collaborator Author

blt commented Dec 18, 2024

Merge activity

  • Dec 18, 1:01 PM EST: A user merged this pull request with Graphite.

@blt blt deleted the blt/migrate_tonic_to_workspace branch December 18, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants