Skip to content

Conversation

@wantsui
Copy link
Collaborator

@wantsui wantsui commented Dec 4, 2025

What does this PR do?

Adds process tags to instrumentation telemetry for https://datadoghq.atlassian.net/browse/AIDM-255

Motivation:

https://datadoghq.atlassian.net/browse/AIDM-255

Follows the work done in #5033

The Python implementation that I followed can be found here: DataDog/dd-trace-py#15227
Change log entry

None.

Additional Notes:

How to test the change?

docker compose run --rm tracer-3.3 /bin/bash
bundle exec rspec spec/datadog/core/telemetry/integration/telemetry_spec.rb

@github-actions github-actions bot added the core Involves Datadog core libraries label Dec 4, 2025
@wantsui wantsui requested a review from marcotc December 4, 2025 19:05
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Typing analysis

Note: Ignored files are excluded from the next sections.

Untyped methods

This PR introduces 1 partially typed method. It decreases the percentage of typed methods from 55.4% to 55.37% (-0.03%).

Partially typed methods (+1-0)Introduced:
sig/datadog/core/telemetry/request.rbs:11
└── def self.tag_process_tags!: (Hash[Symbol, untyped] app, Core::Configuration::Settings config) -> void

If you believe a method or an attribute is rightfully untyped or partially typed, you can add # untyped:accept to the end of the line to remove it from the stats.

@pr-commenter
Copy link

pr-commenter bot commented Dec 4, 2025

Benchmarks

Benchmark execution time: 2025-12-10 21:58:59

Comparing candidate commit 0ace8cd in PR branch add-process-tags-to-telemetry with baseline commit 80b8b5a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics.

@wantsui wantsui marked this pull request as ready for review December 9, 2025 20:49
@wantsui wantsui requested a review from a team as a code owner December 9, 2025 20:49
@wantsui wantsui requested review from marcotc and p-datadog December 9, 2025 20:50
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Dec 9, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 97.37%
Total Coverage: 95.24% (-0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
* Fix with Cursor requires Datadog plugin ≥v2.17.0
🔗 Commit SHA: 0ace8cd | Docs | Datadog PR Page | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Involves Datadog core libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants