Skip to content

Conversation

@wantsui
Copy link
Collaborator

@wantsui wantsui commented Dec 9, 2025

What does this PR do?

Adds process tags to the dynamic instrumentation payloads, similar to what the dd-trace-py is doing today with DataDog/dd-trace-py#15225 .

Motivation:

For https://datadoghq.atlassian.net/browse/AIDM-256

Change log entry

None.

Additional Notes:

Note: This PR should not be merged until #5110 gets merged

How to test the change?

docker compose run --rm tracer-3.3 /bin/bash
bundle exec rspec spec/datadog/di/probe_notification_builder_spec.rb

@wantsui wantsui requested a review from marcotc December 9, 2025 22:00
@wantsui wantsui marked this pull request as ready for review December 9, 2025 22:02
@wantsui wantsui requested a review from a team as a code owner December 9, 2025 22:02
@wantsui wantsui changed the title feat: add process tags to dynamic instrumentation feat(di): add process tags to dynamic instrumentation Dec 9, 2025
@wantsui wantsui changed the title feat(di): add process tags to dynamic instrumentation DI: add process tags to dynamic instrumentation Dec 9, 2025
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
But we for sure want @p-datadog to take a look.

@marcotc marcotc requested a review from p-datadog December 9, 2025 22:24
@pr-commenter
Copy link

pr-commenter bot commented Dec 9, 2025

Benchmarks

Benchmark execution time: 2025-12-09 22:27:22

Comparing candidate commit 37abd0f in PR branch add-process-tags-to-dynamic-instrumentation with baseline commit 2d0d8b1 in branch add-process-tags-to-telemetry.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics.

scenario:profiling - gvl benchmark samples

  • 🟩 throughput [+823.772op/s; +835.108op/s] or [+6.679%; +6.771%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants