Skip to content

chore(telemetry): Update payload batching #14615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: munir/batch-all-telemetry-requests
Choose a base branch
from
+323 −393
Draft

chore(telemetry): Update payload batching #14615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
be30604
perf(telemetry): batch telemetry events into one request
mabdinur Sep 16, 2025
7b36e7b
update smoke test
mabdinur Sep 16, 2025
874eacb
fix broken app started tests
mabdinur Sep 16, 2025
71ca2c1
fix generate metrics and improve sent debug logs
mabdinur Sep 16, 2025
c41db6f
add rn
mabdinur Sep 16, 2025
760c2a0
rm release note
mabdinur Sep 17, 2025
6bb05d2
clean up payload generation
mabdinur Sep 17, 2025
ec26937
use event type
mabdinur Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions ddtrace/internal/telemetry/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,20 @@ class TELEMETRY_NAMESPACE(Enum):
PROFILER = "profiler"


TELEMETRY_TYPE_GENERATE_METRICS = "generate-metrics"
TELEMETRY_TYPE_DISTRIBUTION = "distributions"
TELEMETRY_TYPE_LOGS = "logs"
class TELEMETRY_EVENT_TYPE(Enum):
STARTED = "app-started"
SHUTDOWN = "app-shutdown"
HEARTBEAT = "app-heartbeat"
EXTENDED_HEARTBEAT = "app-extended-heartbeat"
DEPENDENCIES_LOADED = "app-dependencies-loaded"
PRODUCT_CHANGE = "app-product-change"
INTEGRATIONS_CHANGE = "app-integrations-change"
ENDPOINTS = "app-endpoints"
CLIENT_CONFIGURATION_CHANGE = "app-client-configuration-change"
LOGS = "logs"
METRICS = "generate-metrics"
DISTRIBUTIONS = "distributions"
MESSAGE_BATCH = "message-batch"


class TELEMETRY_LOG_LEVEL(Enum):
Expand Down
11 changes: 5 additions & 6 deletions ddtrace/internal/telemetry/metrics_namespaces.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ from typing import Tuple

from ddtrace.internal import forksafe
from ddtrace.internal.telemetry.constants import TELEMETRY_NAMESPACE
from ddtrace.internal.telemetry.constants import TELEMETRY_TYPE_DISTRIBUTION
from ddtrace.internal.telemetry.constants import TELEMETRY_TYPE_GENERATE_METRICS
from ddtrace.internal.telemetry.constants import TELEMETRY_EVENT_TYPE


MetricTagType = Optional[Tuple[Tuple[str, str], ...]]
Expand Down Expand Up @@ -46,14 +45,14 @@ cdef class MetricNamespace:

now = int(time.time())
data = {
TELEMETRY_TYPE_GENERATE_METRICS: {},
TELEMETRY_TYPE_DISTRIBUTION: {},
TELEMETRY_EVENT_TYPE.METRICS: {},
TELEMETRY_EVENT_TYPE.DISTRIBUTIONS: {},
}
for metric_id, value in namespace_metrics.items():
name, namespace, _tags, metric_type = metric_id
tags = ["{}:{}".format(k, v).lower() for k, v in _tags] if _tags else []
if metric_type is MetricType.DISTRIBUTION:
data[TELEMETRY_TYPE_DISTRIBUTION].setdefault(namespace, []).append({
data[TELEMETRY_EVENT_TYPE.DISTRIBUTIONS].setdefault(namespace, []).append({
"metric": name,
"points": value,
"tags": tags,
Expand All @@ -70,7 +69,7 @@ cdef class MetricNamespace:
}
if metric_type in (MetricType.RATE, MetricType.GAUGE):
metric["interval"] = _interval
data[TELEMETRY_TYPE_GENERATE_METRICS].setdefault(namespace, []).append(metric)
data[TELEMETRY_EVENT_TYPE.METRICS].setdefault(namespace, []).append(metric)

return data

Expand Down
Loading
Loading