Skip to content

Conversation

mabdinur
Copy link
Contributor

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Sep 17, 2025

CODEOWNERS have been resolved as:

ddtrace/internal/telemetry/constants.py                                 @DataDog/apm-python
ddtrace/internal/telemetry/metrics_namespaces.pyx                       @DataDog/apm-python
ddtrace/internal/telemetry/writer.py                                    @DataDog/apm-python
tests/appsec/appsec/test_telemetry.py                                   @DataDog/asm-python
tests/appsec/iast/test_telemetry.py                                     @DataDog/asm-python
tests/telemetry/app.py                                                  @DataDog/apm-python
tests/telemetry/test_telemetry.py                                       @DataDog/apm-python
tests/telemetry/test_telemetry_metrics.py                               @DataDog/apm-python
tests/telemetry/test_writer.py                                          @DataDog/apm-python

@mabdinur mabdinur force-pushed the munir/batch-all-telemetry-requests branch from a41cdb8 to c41db6f Compare September 17, 2025 18:08
@mabdinur mabdinur force-pushed the munir/refactor-telemetry-writer branch 2 times, most recently from 51a8244 to ec9571b Compare September 17, 2025 18:12
@mabdinur mabdinur force-pushed the munir/refactor-telemetry-writer branch from ec9571b to ec26937 Compare September 17, 2025 18:16
Copy link
Contributor

github-actions bot commented Sep 17, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 269 ± 4 ms.

The average import time from base is: 274 ± 5 ms.

The import time difference between this PR and base is: -4.3 ± 0.2 ms.

Import time breakdown

The following import paths have grown:

ddtrace.auto 0.148 ms (0.06%)
ddtrace 0.148 ms (0.06%)
ddtrace._logger 0.148 ms (0.06%)
ddtrace.internal.telemetry 0.148 ms (0.06%)
ddtrace.internal.telemetry.constants 0.148 ms (0.06%)

The following import paths have shrunk:

ddtrace.auto 2.199 ms (0.82%)
ddtrace.bootstrap.sitecustomize 1.500 ms (0.56%)
ddtrace.bootstrap.preload 1.500 ms (0.56%)
ddtrace.internal.remoteconfig.client 0.657 ms (0.24%)
ddtrace 0.699 ms (0.26%)
ddtrace.internal._unpatched 0.032 ms (0.01%)
json 0.032 ms (0.01%)
json.decoder 0.032 ms (0.01%)
re 0.032 ms (0.01%)
enum 0.032 ms (0.01%)
types 0.032 ms (0.01%)
ddtrace._logger 0.018 ms (0.01%)
ddtrace.internal.telemetry 0.018 ms (0.01%)
ddtrace.internal.telemetry.writer 0.018 ms (0.01%)
http.client 0.018 ms (0.01%)
email.parser 0.018 ms (0.01%)
email.feedparser 0.018 ms (0.01%)
email._policybase 0.018 ms (0.01%)
email.header 0.018 ms (0.01%)
email.charset 0.018 ms (0.01%)
email.encoders 0.018 ms (0.01%)

@mabdinur mabdinur force-pushed the munir/batch-all-telemetry-requests branch 6 times, most recently from 1d2fc4d to 1b8f44b Compare September 18, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant